[SPARK-34232][CORE][3.0] Redact SparkListenerEnvironmentUpdate event in log #31634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
approved these changes
Feb 24, 2021
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
|
Merged to branch-3.0. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Feb 24, 2021
…in log ### What changes were proposed in this pull request? Redact event SparkListenerEnvironmentUpdate in log when its processing time exceeded logSlowEventThreshold. This is the backport of #31335 to branch-3.0. ### Why are the changes needed? Credentials could be exposed when its processing time exceeded logSlowEventThreshold. As this is related to security issue, it is better to backport it. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Manually tested in original PR. Closes #31634 from viirya/SPARK-34232-3.0. Authored-by: Liang-Chi Hsieh <[email protected]> Signed-off-by: HyukjinKwon <[email protected]>
|
Test build #135414 has finished for PR 31634 at commit
|
|
Thank you @HyukjinKwon! |
rshkv
pushed a commit
to palantir/spark
that referenced
this pull request
Mar 9, 2021
…in log ### What changes were proposed in this pull request? Redact event SparkListenerEnvironmentUpdate in log when its processing time exceeded logSlowEventThreshold. This is the backport of apache#31335 to branch-3.0. ### Why are the changes needed? Credentials could be exposed when its processing time exceeded logSlowEventThreshold. As this is related to security issue, it is better to backport it. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Manually tested in original PR. Closes apache#31634 from viirya/SPARK-34232-3.0. Authored-by: Liang-Chi Hsieh <[email protected]> Signed-off-by: HyukjinKwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Redact event SparkListenerEnvironmentUpdate in log when its processing time exceeded logSlowEventThreshold.
This is the backport of #31335 to branch-3.0.
Why are the changes needed?
Credentials could be exposed when its processing time exceeded logSlowEventThreshold.
As this is related to security issue, it is better to backport it.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Manually tested in original PR.