[SPARK-34749][SQL] Simplify ResolveCreateNamedStruct #31843
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #136078 has finished for PR 31843 at commit
|
|
Could you fix the relevant UT failure? |
|
The scala 2.13 failure is unrelated. Can you take another look? @dongjoon-hyun @maropu , thanks! |
#31862 seems can fix this. |
maropu
reviewed
Mar 17, 2021
| // 4. GetMapValue if `a.b` refers to a map-type column. | ||
| // We should always use the last part of the column name (`c` in the above example) as the | ||
| // alias name inside CreateNamedStruct. | ||
| case (u: UnresolvedAttribute, _) => Seq(Literal(u.nameParts.last), u) |
There was a problem hiding this comment.
Ah, I see. This change makes ResolveCreateNamedStruct simpler. The fix seems smart.
maropu
approved these changes
Mar 17, 2021
maropu
changed the title
|
Thanks! Merged to master. |
|
The commit has a conflict with branch-3.1. Is it better to merge this in branch-3.1, too, because this is a follow-up of #31808? If so, could you open a backport PR for the fix? |
cloud-fan
added a commit
to cloud-fan/spark
that referenced
this pull request
Mar 17, 2021
This is a follow-up of apache#31808 and simplifies its fix to one line (excluding comments). code simplification no N/A Closes apache#31843 from cloud-fan/simplify. Authored-by: Wenchen Fan <[email protected]> Signed-off-by: Takeshi Yamamuro <[email protected]>
maropu
pushed a commit
that referenced
this pull request
Mar 17, 2021
backports #31843 ### What changes were proposed in this pull request? This is a follow-up of #31808 and simplifies its fix to one line (excluding comments). ### Why are the changes needed? code simplification ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? N/A Closes #31867 from cloud-fan/backport. Authored-by: Wenchen Fan <[email protected]> Signed-off-by: Takeshi Yamamuro <[email protected]>
flyrain
pushed a commit
to flyrain/spark
that referenced
this pull request
Sep 21, 2021
backports apache#31843 ### What changes were proposed in this pull request? This is a follow-up of apache#31808 and simplifies its fix to one line (excluding comments). ### Why are the changes needed? code simplification ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? N/A Closes apache#31867 from cloud-fan/backport. Authored-by: Wenchen Fan <[email protected]> Signed-off-by: Takeshi Yamamuro <[email protected]>
fishcus
pushed a commit
to fishcus/spark
that referenced
this pull request
Jan 12, 2022
backports apache#31843 ### What changes were proposed in this pull request? This is a follow-up of apache#31808 and simplifies its fix to one line (excluding comments). ### Why are the changes needed? code simplification ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? N/A Closes apache#31867 from cloud-fan/backport. Authored-by: Wenchen Fan <[email protected]> Signed-off-by: Takeshi Yamamuro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a follow-up of #31808 and simplifies its fix to one line (excluding comments).
Why are the changes needed?
code simplification
Does this PR introduce any user-facing change?
no
How was this patch tested?
N/A