Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BRANCH-1.1][SPARK-2652] change the default spark.serializer in pyspark back to Kryo #3187

Closed
wants to merge 1 commit into from
Closed

[BRANCH-1.1][SPARK-2652] change the default spark.serializer in pyspark back to Kryo #3187

wants to merge 1 commit into from
+1 −0

Conversation

mengxr
Copy link
Contributor

@mengxr mengxr commented Nov 10, 2014

This reverts #2916 . We shouldn't change the default settings in a minor release. @JoshRosen @davies

@davies
Copy link
Contributor

davies commented Nov 10, 2014

LGTM

@SparkQA
Copy link

SparkQA commented Nov 10, 2014

QA tests have started for PR 3187 at commit 372166b.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Nov 10, 2014

QA tests have finished for PR 3187 at commit 372166b.

  • This patch fails unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23157/
Test FAILed.

@mengxr mengxr mentioned this pull request Nov 10, 2014
Closed
@mengxr
Copy link
Contributor Author

mengxr commented Nov 10, 2014

test this please

@SparkQA
Copy link

SparkQA commented Nov 10, 2014

QA tests have started for PR 3187 at commit 372166b.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Nov 10, 2014

QA tests have finished for PR 3187 at commit 372166b.

  • This patch fails unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23162/
Test FAILed.

@mengxr
Copy link
Contributor Author

mengxr commented Nov 10, 2014

test this please

@SparkQA
Copy link

SparkQA commented Nov 10, 2014

QA tests have started for PR 3187 at commit 372166b.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Nov 10, 2014

QA tests have finished for PR 3187 at commit 372166b.

  • This patch fails unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23164/
Test FAILed.

@mengxr
Copy link
Contributor Author

mengxr commented Nov 10, 2014

test this please

@SparkQA
Copy link

SparkQA commented Nov 10, 2014

QA tests have started for PR 3187 at commit 372166b.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Nov 11, 2014

QA tests have finished for PR 3187 at commit 372166b.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23169/
Test PASSed.

@andrewor14
Copy link
Contributor

Hey @mengxr is this good to merge?

@mengxr
Copy link
Contributor Author

mengxr commented Nov 11, 2014

Yes. I've merged this into branch-1.1.

asfgit pushed a commit that referenced this pull request Nov 11, 2014
@mengxr
[BRANCH-1.1][SPARK-2652] change the default spark.serializer in pyspa…
11798d0 
…rk back to Kryo

This reverts #2916 . We shouldn't change the default settings in a minor release. JoshRosen davies

Author: Xiangrui Meng <[email protected]>

Closes #3187 from mengxr/SPARK-2652-1.1 and squashes the following commits:

372166b [Xiangrui Meng] change the default spark.serializer in pyspark back to Kryo
asfgit pushed a commit that referenced this pull request Nov 11, 2014
@mengxr
[branch-1.1][SPARK-3990] add a note on ALS usage
b2cb357 
Because we switched back to Kryo in #3187 , we need to leave a note about the workaround.

Author: Xiangrui Meng <[email protected]>

Closes #3190 from mengxr/SPARK-3990-1.1 and squashes the following commits:

d4818f3 [Xiangrui Meng] fix python style
53725b0 [Xiangrui Meng] add a note about SPARK-3990
56ad70e [Xiangrui Meng] add a note about SPARK-3990
@mengxr mengxr closed this Nov 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mengxr @davies @SparkQA @AmplabJenkins @andrewor14