[SPARK-35467][SPARK-35468][SPARK-35477][PYTHON] Fix disallow_untyped_defs mypy checks. #32627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #138819 has finished for PR 32627 at commit
|
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Test build #138826 has finished for PR 32627 at commit
|
|
Kubernetes integration test unable to build dist. exiting with code: 1 |
srowen
approved these changes
May 22, 2021
HyukjinKwon
approved these changes
May 23, 2021
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Adds more type annotations in the files:
python/pyspark/pandas/spark/accessors.pypython/pyspark/pandas/typedef/typehints.pypython/pyspark/pandas/utils.pyand fixes the mypy check failures.
Why are the changes needed?
We should enable more
disallow_untyped_defsmypy checks.Does this PR introduce any user-facing change?
Yes.
This PR adds more type annotations in pandas APIs on Spark module, which can impact interaction with development tools for users.
How was this patch tested?
The mypy check with a new configuration and existing tests should pass.