Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-4468][SQL] Backports #3334 to branch-1.1 #3338

Closed
wants to merge 1 commit into from
Closed

[SPARK-4468][SQL] Backports #3334 to branch-1.1 #3338

wants to merge 1 commit into from

Conversation

liancheng
Copy link
Contributor

Review on Reviewable

@liancheng liancheng mentioned this pull request Nov 18, 2014
Closed
@SparkQA
Copy link

SparkQA commented Nov 18, 2014

QA tests have started for PR 3338 at commit bd17512.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Nov 18, 2014

QA tests have finished for PR 3338 at commit bd17512.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23540/
Test PASSed.

@marmbrus
Copy link
Contributor

Thanks! Merged to branch-1.1

marmbrus pushed a commit to marmbrus/spark that referenced this pull request Nov 19, 2014
@liancheng @marmbrus
[SPARK-4468][SQL] Fixes Parquet filter creation for inequality predic…
423baea 
…ates with literals on the left hand side

For expressions like `10 < someVar`, we should create an `Operators.Gt` filter, but right now an `Operators.Lt` is created. This issue affects all inequality predicates with literals on the left hand side.

(This bug existed before apache#3317 and affects branch-1.1. apache#3338 was opened to backport this to branch-1.1.)

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/apache/spark/3334)
<!-- Reviewable:end -->

Author: Cheng Lian <[email protected]>

Closes apache#3334 from liancheng/fix-parquet-comp-filter and squashes the following commits:

0130897 [Cheng Lian] Fixes Parquet comparison filter generation
liancheng added a commit that referenced this pull request Nov 19, 2014
@liancheng @marmbrus
[SPARK-4468][SQL] Fixes Parquet filter creation for inequality predic…
790c874 
…ates with literals on the left hand side

For expressions like `10 < someVar`, we should create an `Operators.Gt` filter, but right now an `Operators.Lt` is created. This issue affects all inequality predicates with literals on the left hand side.

(This bug existed before #3317 and affects branch-1.1. #3338 was opened to backport this to branch-1.1.)

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/apache/spark/3334)
<!-- Reviewable:end -->

Author: Cheng Lian <[email protected]>

Closes #3334 from liancheng/fix-parquet-comp-filter and squashes the following commits:

0130897 [Cheng Lian] Fixes Parquet comparison filter generation

(cherry picked from commit 423baea)
Signed-off-by: Michael Armbrust <[email protected]>
@andrewor14
Copy link
Contributor

Hey @liancheng can you close this? It's already merged

@liancheng liancheng closed this Nov 20, 2014
@liancheng liancheng deleted the spark-3334-for-1.1 branch November 20, 2014 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@liancheng @SparkQA @AmplabJenkins @marmbrus @andrewor14