-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-4837] NettyBlockTransferService should use spark.blockManager.port config #3688
Conversation
Test build #24430 has started for PR 3688 at commit
|
Test build #24430 has finished for PR 3688 at commit
|
Test FAILed. |
Jenkins, retest this please. |
Test build #24441 has started for PR 3688 at commit
|
Test build #24441 has finished for PR 3688 at commit
|
Test FAILed. |
Jenkins, retest this please. |
Test build #24503 has started for PR 3688 at commit
|
Test build #24503 has finished for PR 3688 at commit
|
Test PASSed. |
LGTM. |
LGTM, too, so I'm going to merge this into |
…port config This is used in NioBlockTransferService here: https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/network/nio/NioBlockTransferService.scala#L66 Author: Aaron Davidson <[email protected]> Closes #3688 from aarondav/SPARK-4837 and squashes the following commits: ebd2007 [Aaron Davidson] [SPARK-4837] NettyBlockTransferService should use spark.blockManager.port config (cherry picked from commit 105293a) Signed-off-by: Josh Rosen <[email protected]>
this fix doesn't work when both executor and driver are running on the same machine (as they are trying to acquire the same port) |
@dizzy2 Sorry, thought I responded earlier -- you are quite right. It should be a straightforward fix of adding a |
This is used in NioBlockTransferService here:
https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/network/nio/NioBlockTransferService.scala#L66