Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-4864] Add documentation to Netty-based configs #3713

Closed
wants to merge 2 commits into from
Closed

[SPARK-4864] Add documentation to Netty-based configs #3713

wants to merge 2 commits into from

Conversation

aarondav
Copy link
Contributor

No description provided.

@SparkQA
Copy link

SparkQA commented Dec 16, 2014

Test build #24505 has started for PR 3713 at commit 3b1f84e.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Dec 16, 2014

Test build #24505 has finished for PR 3713 at commit 3b1f84e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24505/
Test PASSed.

pwendell
pwendell reviewed Dec 17, 2014
View reviewed changes
docs/configuration.md
<td>1</td>
<td>
(Netty only) Connections between hosts are reused in order to reduce connection buildup for
large clusters. For small clusters with many hard disks, this may result in insufficient
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this say many hard disks and a small number of hosts?

@pwendell
Copy link
Contributor

Hey Aaron,

This looks good overall but I wonder whether we should leave out serverThreads and clientThreads for now. At least on the surface of it I'm not sure users would really understand when they need to adjust it, and the doc itself says they likely wouldn't need to adjust it ever.

@aarondav
Copy link
Contributor Author

Addressed your comments -- removed server/clientThreads

@SparkQA
Copy link

SparkQA commented Dec 17, 2014

Test build #24559 has started for PR 3713 at commit 8a8b373.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Dec 18, 2014

Test build #24559 has finished for PR 3713 at commit 8a8b373.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24559/
Test PASSed.

@pwendell
Copy link
Contributor

Thanks - I merged this.

asfgit pushed a commit that referenced this pull request Dec 22, 2014
@aarondav @pwendell
[SPARK-4864] Add documentation to Netty-based configs
4b2bded 
Author: Aaron Davidson <[email protected]>

Closes #3713 from aarondav/netty-configs and squashes the following commits:

8a8b373 [Aaron Davidson] Address Patrick's comments
3b1f84e [Aaron Davidson] [SPARK-4864] Add documentation to Netty-based configs

(cherry picked from commit fbca6b6)
Signed-off-by: Patrick Wendell <[email protected]>
@asfgit asfgit closed this in fbca6b6 Dec 22, 2014
@sarutak sarutak mentioned this pull request Jan 13, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aarondav @SparkQA @AmplabJenkins @pwendell