Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-4985] [SQL] parquet support for date type #3822

Closed
wants to merge 3 commits into from
Closed

[SPARK-4985] [SQL] parquet support for date type #3822

wants to merge 3 commits into from

Conversation

adrian-wang
Copy link
Contributor

This PR might have some issues with #3732 ,
and this would have merge conflicts with #3820 so the review can be delayed till that 2 were merged.

@SparkQA
Copy link

SparkQA commented Dec 29, 2014

Test build #24856 has started for PR 3822 at commit 0ebe356.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Dec 29, 2014

Test build #24856 has finished for PR 3822 at commit 0ebe356.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24856/
Test PASSed.

@adrian-wang adrian-wang changed the title [SPARK-4985] [SQL] parquet support for date type [SPARK-4985] [SQL] [WIP] parquet support for date type Jan 27, 2015
@SparkQA
Copy link

SparkQA commented Feb 9, 2015

Test build #27084 has started for PR 3822 at commit b3ec9b0.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Feb 9, 2015

Test build #27084 has finished for PR 3822 at commit b3ec9b0.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27084/
Test PASSed.

@adrian-wang adrian-wang changed the title [SPARK-4985] [SQL] [WIP] parquet support for date type [SPARK-4985] [SQL] parquet support for date type Feb 9, 2015
@adrian-wang adrian-wang changed the title [SPARK-4985] [SQL] parquet support for date type [SPARK-4985] [SQL] [WIP] parquet support for date type Feb 9, 2015
@SparkQA
Copy link

SparkQA commented Feb 25, 2015

Test build #27937 has started for PR 3822 at commit 64cc041.

  • This patch merges cleanly.

@adrian-wang adrian-wang changed the title [SPARK-4985] [SQL] [WIP] parquet support for date type [SPARK-4985] [SQL] parquet support for date type Feb 25, 2015
@SparkQA
Copy link

SparkQA commented Feb 25, 2015

Test build #27937 has finished for PR 3822 at commit 64cc041.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27937/
Test PASSed.

@adrian-wang
Copy link
Contributor Author

HIVE-8119 have been merged into hive trunk. I'll test my patch based on that.

@adrian-wang
Copy link
Contributor Author

I have tested my code with hive trunk, it is compatible.

/cc @marmbrus @rxin @liancheng @yhuai

@marmbrus
Copy link
Contributor

This looks pretty good to me. Can you add a test that actually exercises the read/write path?

@marmbrus marmbrus mentioned this pull request Mar 18, 2015
Closed
@SparkQA
Copy link

SparkQA commented Mar 18, 2015

Test build #28777 has started for PR 3822 at commit d41fb0c.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Mar 18, 2015

Test build #28777 has finished for PR 3822 at commit d41fb0c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28777/
Test PASSed.

@marmbrus
Copy link
Contributor

Sorry, looks like this has conflicts again. :( I would love to include it in 1.3.1 if you have time to update soon! :)

@adrian-wang
Copy link
Contributor Author

rebased

@SparkQA
Copy link

SparkQA commented Mar 22, 2015

Test build #28966 has started for PR 3822 at commit 2c5d54d.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Mar 22, 2015

Test build #28966 has finished for PR 3822 at commit 2c5d54d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28966/
Test PASSed.

@adrian-wang
Copy link
Contributor Author

@marmbrus

@asfgit asfgit closed this in 4659468 Mar 23, 2015
asfgit pushed a commit that referenced this pull request Mar 23, 2015
@adrian-wang @liancheng
[SPARK-4985] [SQL] parquet support for date type
60b9b96 
This PR might have some issues with #3732 ,
and this would have merge conflicts with #3820 so the review can be delayed till that 2 were merged.

Author: Daoyuan Wang <[email protected]>

Closes #3822 from adrian-wang/parquetdate and squashes the following commits:

2c5d54d [Daoyuan Wang] add a test case
faef887 [Daoyuan Wang] parquet support for primitive date
97e9080 [Daoyuan Wang] parquet support for date type

(cherry picked from commit 4659468)
Signed-off-by: Cheng Lian <[email protected]>
@liancheng
Copy link
Contributor

Thanks! Merged into master and branch-1.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@adrian-wang @SparkQA @AmplabJenkins @marmbrus @liancheng