Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Spark-5717] [MLlib] add stop and reorganize import #4503

Closed
wants to merge 2 commits into from
Closed

[Spark-5717] [MLlib] add stop and reorganize import #4503

wants to merge 2 commits into from

Conversation

hhbyyh
Copy link
Contributor

@hhbyyh hhbyyh commented Feb 10, 2015

Trivial. add sc stop and reorganize import
https://issues.apache.org/jira/browse/SPARK-5717

@SparkQA
Copy link

SparkQA commented Feb 10, 2015

Test build #27198 has started for PR 4503 at commit 2e85cc1.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Feb 10, 2015

Test build #27198 has finished for PR 4503 at commit 2e85cc1.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27198/
Test FAILed.

@hhbyyh
Copy link
Contributor Author

hhbyyh commented Feb 10, 2015

The ut failure seems irrelevant. Not sure how to trigger the retest properly.

srowen
srowen reviewed Feb 10, 2015
View reviewed changes
examples/src/main/scala/org/apache/spark/examples/mllib/LDAExample.scala
import org.apache.spark.mllib.clustering.LDA
import org.apache.spark.mllib.linalg.{Vector, Vectors}
import org.apache.spark.rdd.RDD

import org.apache.spark.{SparkConf, SparkContext}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Spark imports were correctly ordered already. I think the scopt import could go after the log4j import, if we're matching style of other imports.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

@srowen
Copy link
Member

srowen commented Feb 10, 2015

Yes it's a small thing but the examples should call stop(). I can merge if you'll move the imports accordingly.

@SparkQA
Copy link

SparkQA commented Feb 10, 2015

Test build #27208 has started for PR 4503 at commit 7837a2c.

  • This patch merges cleanly.

@srowen
Copy link
Member

srowen commented Feb 10, 2015

jenkins, retest this please

@SparkQA
Copy link

SparkQA commented Feb 10, 2015

Test build #27209 has started for PR 4503 at commit 7837a2c.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Feb 10, 2015

Test build #27208 has finished for PR 4503 at commit 7837a2c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27208/
Test PASSed.

@SparkQA
Copy link

SparkQA commented Feb 10, 2015

Test build #27209 has finished for PR 4503 at commit 7837a2c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27209/
Test PASSed.

asfgit pushed a commit that referenced this pull request Feb 10, 2015
@srowen
[Spark-5717] [MLlib] add stop and reorganize import
b32f553 
Trivial. add sc stop and reorganize import
https://issues.apache.org/jira/browse/SPARK-5717

Author: JqueryFan <[email protected]>
Author: Yuhao Yang <[email protected]>

Closes #4503 from hhbyyh/scstop and squashes the following commits:

7837a2c [JqueryFan] revert import change
2e85cc1 [Yuhao Yang] add stop and reorganize import

(cherry picked from commit 6cc96cf)
Signed-off-by: Sean Owen <[email protected]>
@asfgit asfgit closed this in 6cc96cf Feb 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hhbyyh @SparkQA @AmplabJenkins @srowen