[SPARK-47500][PYTHON][CONNECT] Factor column name handling out of plan.py
#45636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhengruifeng
force-pushed
the
plan_clean_up
branch
from
b1aa90e to
bf6f2bc
Compare
zhengruifeng
force-pushed
the
plan_clean_up
branch
from
3c3c7ea to
dc6efaf
Compare
HyukjinKwon
approved these changes
Mar 22, 2024
|
Merged to master. |
sweisdb
pushed a commit
to sweisdb/spark
that referenced
this pull request
Apr 1, 2024
…an.py` ### What changes were proposed in this pull request? Factor column name handling out of `plan.py` ### Why are the changes needed? there are too many parameters preprocessing in `plan.py`, e.g. the column name handling, there are multiple duplicated helper functions here and there, make it hard to follow some times. ### Does this PR introduce _any_ user-facing change? no, just code refactor ### How was this patch tested? ci ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#45636 from zhengruifeng/plan_clean_up. Authored-by: Ruifeng Zheng <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
HyukjinKwon
pushed a commit
that referenced
this pull request
Jun 11, 2024
…ataFrame.select(None)` ### What changes were proposed in this pull request? the refactor PR #45636 changed the error message of `DataFrame.select(None)` from `PySparkTypeError` to `AssertionError`, this PR restore the previous error message ### Why are the changes needed? error message improvement ### Does this PR introduce _any_ user-facing change? yes, error message improvement ### How was this patch tested? added test ### Was this patch authored or co-authored using generative AI tooling? no Closes #46930 from zhengruifeng/py_restore_select_error. Authored-by: Ruifeng Zheng <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Factor column name handling out of
plan.pyWhy are the changes needed?
there are too many parameters preprocessing in
plan.py, e.g. the column name handling,there are multiple duplicated helper functions here and there, make it hard to follow some times.
Does this PR introduce any user-facing change?
no, just code refactor
How was this patch tested?
ci
Was this patch authored or co-authored using generative AI tooling?
no