-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-48560][SS][PYTHON] Make StreamingQueryListener.spark settable #46909
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for the fix! |
WweiL
approved these changes
Jun 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending fixing lint
zhengruifeng
approved these changes
Jun 7, 2024
zsxwing
reviewed
Jun 7, 2024
xinrong-meng
approved these changes
Jun 7, 2024
489563e
to
9bd8aea
Compare
9bd8aea
to
562ef6f
Compare
Will fix up the test |
Merged to master. |
This is awesome. Thanks @HyukjinKwon . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to make StreamingQueryListener.spark settable
Why are the changes needed?
is broken from 3.5.0 after SPARK-42941.
Does this PR introduce any user-facing change?
Yes, end users who implement
StreamingQueryListener
can addspark
attribute in their implementation.How was this patch tested?
Manually tested, and added a unittest.
Was this patch authored or co-authored using generative AI tooling?
No.