-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-48772][SS][SQL] State Data Source Change Feed Reader Mode #47188
Closed
Closed
Changes from 18 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
1ade442
Squashed commit of the following:
eason-yuchen-liu 98bf8ec
revert unnecessary changes
eason-yuchen-liu fb890ae
Merge branch 'master' into readStateChange
eason-yuchen-liu db45c6f
Add comments
eason-yuchen-liu 1926e5e
Merge branch 'readStateChange' of https://github.com/eason-yuchen-liu…
eason-yuchen-liu 24c0351
minor
eason-yuchen-liu d4a4b80
group options & make options in changeFeed mode isolate from some opt…
eason-yuchen-liu 42552ac
reorder the columns in the result
eason-yuchen-liu 24db837
address comments from Jungtaek
eason-yuchen-liu adde991
minor
eason-yuchen-liu d3ca86c
refactor StatePartitionReader for both modes
eason-yuchen-liu 5199c56
minor
eason-yuchen-liu ce75133
Use NextIterator as the interface rather than StateStoreChangeDataRea…
eason-yuchen-liu 84dcf15
more doc
eason-yuchen-liu 22a086b
Merge branch 'master' into readStateChange
eason-yuchen-liu c797d0b
use Jungtaek's advice in checking schema validity
eason-yuchen-liu 5921479
Merge branch 'readStateChange' of https://github.com/eason-yuchen-liu…
eason-yuchen-liu e5674cf
solve column family merge conflict
eason-yuchen-liu c012e1a
pass tests
eason-yuchen-liu ff0cd43
continue
eason-yuchen-liu 2ad7590
make the doc consistent
eason-yuchen-liu 43420f6
continue
eason-yuchen-liu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd expect
change_type
andbatch_id
to begin with, and even batch ID to be placed earlier (batch_id, change_type).Given the characteristic of change feed, the output is expected to be ordered by batch ID (among partition IDs, which may be uneasy), or even the data source does not do so, users should be able to do so easily because they will high likely do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense.