Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-5951][YARN] Remove unreachable driver memory properties in yarn client mode #4730

Closed
wants to merge 1 commit into from

Conversation

zuxqoj
Copy link
Contributor

@zuxqoj zuxqoj commented Feb 23, 2015

Remove unreachable driver memory properties in yarn client mode

@zuxqoj zuxqoj changed the title SPARK-5951 [SPARK-5951][YARN] Remove unreachable driver memory properties in yarn client mode Feb 23, 2015
@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@sryza
Copy link
Contributor

sryza commented Feb 23, 2015

LGTM. This seems in line with SPARK-1953's eradication of these properties for yarn-client mode.

@srowen
Copy link
Member

srowen commented Feb 24, 2015

Does @andrewor14 's comment at #3590 (comment) affect this PR? should more stuff be removed for 1.4?

@zuxqoj
Copy link
Contributor Author

zuxqoj commented Feb 24, 2015

@srowen
Does @andrewor14 's comment at #3590 (comment) affect this PR?
no, he is talking about removing deprecated properties (SPARK_MASTER_MEMORY and spark.master.memory) from spark in 1.4

@andrewor14
Copy link
Contributor

ok to test

@SparkQA
Copy link

SparkQA commented Feb 24, 2015

Test build #27894 has started for PR 4730 at commit 977dc96.

  • This patch merges cleanly.

@andrewor14
Copy link
Contributor

@zuxqoj Thanks for this PR. Actually I'd suggest that we just remove all the deprecated properties here. Calling a Spark executor a "Worker" is just as misleading as calling a Spark driver a "Master".

@SparkQA
Copy link

SparkQA commented Feb 24, 2015

Test build #27894 has finished for PR 4730 at commit 977dc96.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27894/
Test PASSed.

@andrewor14
Copy link
Contributor

I just realized that this patch doesn't actually remove support for those deprecated configs; they were already removed in a patch #3607 that was merged beforehand. What this patch does is just to stop showing the deprecation messages for these configs that were no longer even supported.

LGTM I'm merging this into master and 1.3. Removing support for other deprecated env vars and configs does seem like a different issue.

asfgit pushed a commit that referenced this pull request Feb 26, 2015
…n client mode

Remove unreachable driver memory properties in yarn client mode

Author: mohit.goyal <[email protected]>

Closes #4730 from zuxqoj/master and squashes the following commits:

977dc96 [mohit.goyal] remove not rechable deprecated variables in yarn client mode

(cherry picked from commit b38dec2)
Signed-off-by: Andrew Or <[email protected]>
@asfgit asfgit closed this in b38dec2 Feb 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants