-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-5951][YARN] Remove unreachable driver memory properties in yarn client mode #4730
Conversation
Can one of the admins verify this patch? |
LGTM. This seems in line with SPARK-1953's eradication of these properties for yarn-client mode. |
Does @andrewor14 's comment at #3590 (comment) affect this PR? should more stuff be removed for 1.4? |
@srowen |
ok to test |
Test build #27894 has started for PR 4730 at commit
|
@zuxqoj Thanks for this PR. Actually I'd suggest that we just remove all the deprecated properties here. Calling a Spark executor a "Worker" is just as misleading as calling a Spark driver a "Master". |
Test build #27894 has finished for PR 4730 at commit
|
Test PASSed. |
I just realized that this patch doesn't actually remove support for those deprecated configs; they were already removed in a patch #3607 that was merged beforehand. What this patch does is just to stop showing the deprecation messages for these configs that were no longer even supported. LGTM I'm merging this into master and 1.3. Removing support for other deprecated env vars and configs does seem like a different issue. |
…n client mode Remove unreachable driver memory properties in yarn client mode Author: mohit.goyal <[email protected]> Closes #4730 from zuxqoj/master and squashes the following commits: 977dc96 [mohit.goyal] remove not rechable deprecated variables in yarn client mode (cherry picked from commit b38dec2) Signed-off-by: Andrew Or <[email protected]>
Remove unreachable driver memory properties in yarn client mode