SPARK-2168 [Spark core] Use relative URIs for the app links in the History Server. #4778
Conversation
|
Can one of the admins verify this patch? |
|
ok to test |
|
Test build #27998 has started for PR 4778 at commit
|
|
Test build #27998 has finished for PR 4778 at commit
|
|
Test PASSed. |
| val response = page.render(request) | ||
|
|
||
| //then | ||
| val links = response \\ "a" |
There was a problem hiding this comment.
A bunch of little style nits: The indentation is off by one here. Also I think the imports could be ordered, with scala import first and separated by a line. Fix the extra space in true ) above. Don't we need to import postfixOps to avoid a compiler warning? Do the historyServer and request have to be members?
Otherwise this looks just fine as a follow-on test.
There was a problem hiding this comment.
I compare indentation with FsHistoryProviderSuite and imho its the same, imports will do.
I don't think postfixOps is actually needed here. I will make historyServer and request local variables.
|
Test build #28047 has started for PR 4778 at commit
|
|
Test build #28047 has finished for PR 4778 at commit
|
|
Test PASSed. |
|
Ok LGTM merging into master 1.3 thanks @elyast |
…story Server. As agreed in PR #1160 adding test to verify if history server generates relative links to applications. Author: Lukasz Jastrzebski <[email protected]> Closes #4778 from elyast/master and squashes the following commits: 0c07fab [Lukasz Jastrzebski] Incorporating comments for SPARK-2168 6d7866d [Lukasz Jastrzebski] Adjusting test for SPARK-2168 for master branch d6f4fbe [Lukasz Jastrzebski] Added test for SPARK-2168 (cherry picked from commit 4a8a0a8) Signed-off-by: Andrew Or <[email protected]>
As agreed in PR #1160 adding test to verify if history server generates relative links to applications.