[SPARK-6037][SQL] Avoiding duplicate Parquet schema merging #4786
+7
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #27996 has finished for PR 4786 at commit
|
|
@liancheng #4768 just explained why you need to do merging. The problem is, before the reading task is launched, the different schemas are already merged in |
|
Oh I see, you didn't cancel the change, but reused the merged schema, makes sense, thanks! Merging to master and branch-1.3. |
asfgit
pushed a commit
that referenced
this pull request
Feb 27, 2015
`FilteringParquetRowInputFormat` manually merges Parquet schemas before computing splits. However, it is duplicate because the schemas are already merged in `ParquetRelation2`. We don't need to re-merge them at `InputFormat`. Author: Liang-Chi Hsieh <[email protected]> Closes #4786 from viirya/dup_parquet_schemas_merge and squashes the following commits: ef78a5a [Liang-Chi Hsieh] Avoiding duplicate Parquet schema merging. (cherry picked from commit 4ad5153) Signed-off-by: Cheng Lian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FilteringParquetRowInputFormatmanually merges Parquet schemas before computing splits. However, it is duplicate because the schemas are already merged inParquetRelation2. We don't need to re-merge them atInputFormat.