SPARK-4300 [CORE] Race condition during SparkWorker shutdown #4787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d exception on reading closed input stream
|
Test build #27999 has started for PR 4787 at commit
|
|
Test build #27999 has finished for PR 4787 at commit
|
|
Test FAILed. |
|
Jenkins, retest this please |
|
Test build #28001 has started for PR 4787 at commit
|
|
Test build #28001 has finished for PR 4787 at commit
|
|
Test PASSed. |
|
LGTM. This is similar to #4788. I'm merging this into master and 1.2, and marking it to be back ported into 1.3 later. |
asfgit
pushed a commit
that referenced
this pull request
Feb 26, 2015
Close appender saving stdout/stderr before destroying process to avoid exception on reading closed input stream. (This also removes a redundant `waitFor()` although it was harmless) CC tdas since I think you wrote this method. Author: Sean Owen <[email protected]> Closes #4787 from srowen/SPARK-4300 and squashes the following commits: e0cdabf [Sean Owen] Close appender saving stdout/stderr before destroying process to avoid exception on reading closed input stream (cherry picked from commit 3fb53c0) Signed-off-by: Andrew Or <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
Mar 13, 2015
Close appender saving stdout/stderr before destroying process to avoid exception on reading closed input stream. (This also removes a redundant `waitFor()` although it was harmless) CC tdas since I think you wrote this method. Author: Sean Owen <[email protected]> Closes #4787 from srowen/SPARK-4300 and squashes the following commits: e0cdabf [Sean Owen] Close appender saving stdout/stderr before destroying process to avoid exception on reading closed input stream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close appender saving stdout/stderr before destroying process to avoid exception on reading closed input stream.
(This also removes a redundant
waitFor()although it was harmless)CC @tdas since I think you wrote this method.