[SPARK-6046] Privatize SparkConf.translateConfKey #4797
Conversation
|
Test build #28026 has started for PR 4797 at commit
|
|
LGTM. |
| .orElse(conf.getOption(SparkConf.translateConfKey("spark.history.fs.updateInterval", true))) | ||
| .orElse(conf.getOption(SparkConf.translateConfKey("spark.history.updateInterval", true))) | ||
| .orElse(conf.getOption("spark.history.fs.updateInterval")) | ||
| .orElse(conf.getOption("spark.history.updateInterval")) |
There was a problem hiding this comment.
BTW, it's not necessary to call get with the old names here. The code in SparkConf will print the deprecation warning when the old option names are set, and internally translateKey will always ensure the new option name is used. So the two orElse here are basically reduntant.
There was a problem hiding this comment.
Yeah, with the existing code that is the case. However, there's an issue with translating the configs on conf.set that I outline in #4799. Once we fix that we'll still need the orElses here, but let's move the discussion to that PR instead.
|
Test build #28026 has finished for PR 4797 at commit
|
|
Test PASSed. |
|
Merging into master, thanks. |
The warning of deprecated configs is actually done when the configs are set, not when they are get. As a result we don't need to explicitly call
translateConfKeyoutside ofSparkConfjust to print the warning again in vain.