Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-6058][Yarn] Log the user class exception in ApplicationMaster #4813

Closed
wants to merge 1 commit into from
Closed

[SPARK-6058][Yarn] Log the user class exception in ApplicationMaster #4813

wants to merge 1 commit into from

Conversation

zsxwing
Copy link
Member

@zsxwing zsxwing commented Feb 27, 2015

Because ApplicationMaster doesn't set SparkUncaughtExceptionHandler, the exception in the user class won't be logged. This PR added a logError for it.

@SparkQA
Copy link

SparkQA commented Feb 27, 2015

Test build #28060 has started for PR 4813 at commit 806c932.

  • This patch merges cleanly.

@lianhuiwang
Copy link
Contributor

LGTM

@srowen
Copy link
Member

srowen commented Feb 27, 2015

OK, this is basically an addendum to SPARK-6018 and should follow it. Throwing the exception from a raw Thread won't log it by itself, and it seems the intent was to log the error. Seems fine to explicitly log this and then not throw. LGTM.

@SparkQA
Copy link

SparkQA commented Feb 27, 2015

Test build #28060 timed out for PR 4813 at commit 806c932 after a configured wait of 120m.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28060/
Test FAILed.

@zsxwing
Copy link
Member Author

zsxwing commented Feb 27, 2015

Jenkins, retest this please.

@srowen
Copy link
Member

srowen commented Feb 27, 2015

Jenkins, retest this please

@SparkQA
Copy link

SparkQA commented Feb 27, 2015

Test build #28067 has started for PR 4813 at commit 806c932.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Feb 27, 2015

Test build #28067 has finished for PR 4813 at commit 806c932.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • logError("User class threw exception: " + cause.getMessage, cause)

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28067/
Test PASSed.

asfgit pushed a commit that referenced this pull request Feb 27, 2015
@zsxwing @srowen
[SPARK-6058][Yarn] Log the user class exception in ApplicationMaster
bff8088 
Because ApplicationMaster doesn't set SparkUncaughtExceptionHandler, the exception in the user class won't be logged. This PR added a `logError` for it.

Author: zsxwing <[email protected]>

Closes #4813 from zsxwing/SPARK-6058 and squashes the following commits:

806c932 [zsxwing] Log the user class exception

(cherry picked from commit e747e98)
Signed-off-by: Sean Owen <[email protected]>
@asfgit asfgit closed this in e747e98 Feb 27, 2015
@zsxwing zsxwing deleted the SPARK-6058 branch February 28, 2015 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zsxwing @SparkQA @lianhuiwang @srowen @AmplabJenkins