[SPARK-49845][CORE] Make appArgs and environmentVariables optional in REST API
#48316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
force-pushed
the
SPARK-49845
branch
from
b5b80ef to
d6c00e9
Compare
dongjoon-hyun
force-pushed
the
SPARK-49845
branch
from
d6c00e9 to
1443568
Compare
viirya
approved these changes
Oct 1, 2024
|
Thank you, @viirya ! |
attilapiros
pushed a commit
to attilapiros/spark
that referenced
this pull request
Oct 4, 2024
…l in REST API ### What changes were proposed in this pull request? This PR aims to make `appArgs` and `environmentVariables` fields optional in REST API. ### Why are the changes needed? `appArgs` and `environmentVariables` became mandatory due to the Apache Mesos limitation at Spark 2.2.2. Technically, this is a revert of SPARK-22574. - apache#19966 Since Apache Spark 4.0 removed Mesos support, we don't need these requirements. - apache#43135 ### Does this PR introduce _any_ user-facing change? No because this is a relaxation of enforcement. ### How was this patch tested? Pass the CIs with the revised test case. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#48316 from dongjoon-hyun/SPARK-49845. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
himadripal
pushed a commit
to himadripal/spark
that referenced
this pull request
Oct 19, 2024
…l in REST API ### What changes were proposed in this pull request? This PR aims to make `appArgs` and `environmentVariables` fields optional in REST API. ### Why are the changes needed? `appArgs` and `environmentVariables` became mandatory due to the Apache Mesos limitation at Spark 2.2.2. Technically, this is a revert of SPARK-22574. - apache#19966 Since Apache Spark 4.0 removed Mesos support, we don't need these requirements. - apache#43135 ### Does this PR introduce _any_ user-facing change? No because this is a relaxation of enforcement. ### How was this patch tested? Pass the CIs with the revised test case. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#48316 from dongjoon-hyun/SPARK-49845. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to make
appArgsandenvironmentVariablesfields optional in REST API.Why are the changes needed?
appArgsandenvironmentVariablesbecame mandatory due to the Apache Mesos limitation at Spark 2.2.2. Technically, this is a revert of SPARK-22574.Since Apache Spark 4.0 removed Mesos support, we don't need these requirements.
Does this PR introduce any user-facing change?
No because this is a relaxation of enforcement.
How was this patch tested?
Pass the CIs with the revised test case.
Was this patch authored or co-authored using generative AI tooling?
No.