-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid warning message about invalid refuse_seconds value in Mesos >=0.21... #5597
Conversation
Can one of the admins verify this patch? |
Sounds reasonable, since the value is reported to be invalid. The intent seemed to be to set this to "unset" or something. 5 seems to do something different as it sets it to a concrete value. Knowing nothing about this, is there maybe a closer equivalent value like 0? or is it really best to set this to a fixed value? |
The value 5 seconds is the default value of Mesos, which is used if not The parameter refuse_seconds configures how long Mesos should wait Am 20.04.2015 um 19:03 schrieb Sean Owen:
|
Should a bug should be filed with Mesos to log the error once rather than repeatedly and filling up disk? |
@ash211 That would be nice too. It seems like the -1 Spark sends is considered an invalid value, so it sounds like that much should still change. |
It's logged each time we recover resources in Mesos since that's when we evaluate when the filter should be applied. And yes Mesos needs a positive value for refuse seconds on the filter. I think refused resources could be used when later there more resources available on from the same slave since someone else's task is gone. Also we're adding capacbility into coarse grained scheduler to launched multiple executors, and in addition to that we're putting in dynamic allocation into coarse grained scheduler too. So we will be using refuse resources more often, but 5 as the default sounds reasonable to me. |
….21... Starting with version 0.21.0, Apache Mesos is very noisy if the filter parameter refuse_seconds is set to an invalid value like `-1`. I have seen systems with millions of log lines like ``` W0420 18:00:48.773059 32352 hierarchical_allocator_process.hpp:589] Using the default value of 'refuse_seconds' to create the refused resources filter because the input value is negative ``` in the Mesos master INFO and WARNING log files. Therefore the CoarseMesosSchedulerBackend should set the default value for refuse seconds (i.e. 5 seconds) directly. This is no problem for the fine-grained MesosSchedulerBackend, as it uses the value 1 second for this parameter. Author: mweindel <[email protected]> Closes apache#5597 from MartinWeindel/master and squashes the following commits: 2f99ffd [mweindel] Avoid warning message about invalid refuse_seconds value in Mesos >=0.21.
Starting with version 0.21.0, Apache Mesos is very noisy if the filter parameter refuse_seconds is set to an invalid value like
-1
.I have seen systems with millions of log lines like
in the Mesos master INFO and WARNING log files.
Therefore the CoarseMesosSchedulerBackend should set the default value for refuse seconds (i.e. 5 seconds) directly.
This is no problem for the fine-grained MesosSchedulerBackend, as it uses the value 1 second for this parameter.