Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Build] Always run SQL tests in master build. #5955

Closed
wants to merge 1 commit into from
Closed

[Build] Always run SQL tests in master build. #5955

wants to merge 1 commit into from

Conversation

yhuai
Copy link
Contributor

@yhuai yhuai commented May 6, 2015

Seems our master build does not run HiveCompatibilitySuite (because _RUN_SQL_TESTS is not set). This PR introduces a property AMP_JENKINS_PRB to differentiate a PR build and a regular build. If a build is a regular one, we always set _RUN_SQL_TESTS to true.

cc @JoshRosen @nchammas

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@SparkQA
Copy link

SparkQA commented May 6, 2015

Test build #32046 has started for PR 5955 at commit 3d399bc.

@yhuai
Copy link
Contributor Author

yhuai commented May 6, 2015

Also @pwendell

@nchammas
Copy link
Contributor

nchammas commented May 6, 2015

cc @brennonyork who is converting this whole thing into Python as part of #5694.

@SparkQA
Copy link

SparkQA commented May 7, 2015

Test build #32046 has finished for PR 5955 at commit 3d399bc.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32046/
Test FAILed.

@SparkQA
Copy link

SparkQA commented May 8, 2015

Test build #782 has started for PR 5955 at commit 3d399bc.

@SparkQA
Copy link

SparkQA commented May 8, 2015

Test build #782 has finished for PR 5955 at commit 3d399bc.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented May 8, 2015

Test build #783 has started for PR 5955 at commit 3d399bc.

@SparkQA
Copy link

SparkQA commented May 8, 2015

Test build #783 has finished for PR 5955 at commit 3d399bc.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

scwf
scwf reviewed May 9, 2015
View reviewed changes
dev/run-tests
_RUN_SQL_TESTS=true

if [ -z "$non_sql_diffs" ]; then
echo "[info] Detected no changes except in SQL. Will only run SQL tests."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe "only run SQL related module test suite"

@nchammas nchammas mentioned this pull request May 13, 2015
Closed
@JoshRosen JoshRosen mentioned this pull request May 18, 2015
Closed
@andrewor14
Copy link
Contributor

retest this please

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@SparkQA
Copy link

SparkQA commented May 18, 2015

Test build #33022 has started for PR 5955 at commit 3d399bc.

@SparkQA
Copy link

SparkQA commented May 18, 2015

Test build #33022 has finished for PR 5955 at commit 3d399bc.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33022/
Test FAILed.

@JoshRosen
Copy link
Contributor

I'm going to pull this in now in order to try to expose SQL any SQL test issues in master / 1.4. If this causes any test failures, I'll take the blame and revert.

@JoshRosen
Copy link
Contributor

Actually, my git is having some troubles so I'll do this later.

asfgit pushed a commit that referenced this pull request May 21, 2015
@yhuai @JoshRosen
[BUILD] Always run SQL tests in master build.
2be72c9 
Seems our master build does not run HiveCompatibilitySuite (because _RUN_SQL_TESTS is not set). This PR introduces a property `AMP_JENKINS_PRB` to differentiate a PR build and a regular build. If a build is a regular one, we always set _RUN_SQL_TESTS to true.

cc JoshRosen nchammas

Author: Yin Huai <[email protected]>

Closes #5955 from yhuai/runSQLTests and squashes the following commits:

3d399bc [Yin Huai] Always run SQL tests in master build.

(cherry picked from commit 147b6be)
Signed-off-by: Josh Rosen <[email protected]>
@JoshRosen
Copy link
Contributor

Alright, merged to master and branch-1.4.

@asfgit asfgit closed this in 147b6be May 21, 2015
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request May 28, 2015
@yhuai @jeanlyn
[BUILD] Always run SQL tests in master build.
5981b49 
Seems our master build does not run HiveCompatibilitySuite (because _RUN_SQL_TESTS is not set). This PR introduces a property `AMP_JENKINS_PRB` to differentiate a PR build and a regular build. If a build is a regular one, we always set _RUN_SQL_TESTS to true.

cc JoshRosen nchammas

Author: Yin Huai <[email protected]>

Closes apache#5955 from yhuai/runSQLTests and squashes the following commits:

3d399bc [Yin Huai] Always run SQL tests in master build.
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request Jun 12, 2015
@yhuai @jeanlyn
[BUILD] Always run SQL tests in master build.
ed45f2b 
Seems our master build does not run HiveCompatibilitySuite (because _RUN_SQL_TESTS is not set). This PR introduces a property `AMP_JENKINS_PRB` to differentiate a PR build and a regular build. If a build is a regular one, we always set _RUN_SQL_TESTS to true.

cc JoshRosen nchammas

Author: Yin Huai <[email protected]>

Closes apache#5955 from yhuai/runSQLTests and squashes the following commits:

3d399bc [Yin Huai] Always run SQL tests in master build.
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
@yhuai @nemccarthy
[BUILD] Always run SQL tests in master build.
ae8d5ce 
Seems our master build does not run HiveCompatibilitySuite (because _RUN_SQL_TESTS is not set). This PR introduces a property `AMP_JENKINS_PRB` to differentiate a PR build and a regular build. If a build is a regular one, we always set _RUN_SQL_TESTS to true.

cc JoshRosen nchammas

Author: Yin Huai <[email protected]>

Closes apache#5955 from yhuai/runSQLTests and squashes the following commits:

3d399bc [Yin Huai] Always run SQL tests in master build.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@yhuai @AmplabJenkins @SparkQA @nchammas @andrewor14 @JoshRosen @scwf