Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORE] Protect additional test vars from early GC #6187

Closed
wants to merge 1 commit into from
Closed

[CORE] Protect additional test vars from early GC #6187

wants to merge 1 commit into from

Conversation

tellison
Copy link
Member

Fix more places in which some test variables could be collected early by aggressive JVM optimization.
Added a couple of comments to note where existing references are sufficient in the same test pattern.

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@SparkQA
Copy link

SparkQA commented May 15, 2015

Test build #32826 has started for PR 6187 at commit 27329d9.

@srowen
Copy link
Member

srowen commented May 15, 2015

LGTM for the IBM JDK, just like the last small change

@SparkQA
Copy link

SparkQA commented May 15, 2015

Test build #32826 has finished for PR 6187 at commit 27329d9.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32826/
Test PASSed.

@andrewor14
Copy link
Contributor

Merging into master 1.4

asfgit pushed a commit that referenced this pull request May 15, 2015
Fix more places in which some test variables could be collected early by aggressive JVM optimization.
Added a couple of comments to note where existing references are sufficient in the same test pattern.

Author: Tim Ellison <[email protected]>

Closes #6187 from tellison/DefeatEarlyGC and squashes the following commits:

27329d9 [Tim Ellison] [CORE] Protect additional test vars from early GC

(cherry picked from commit 270d4b5)
Signed-off-by: Andrew Or <[email protected]>
@asfgit asfgit closed this in 270d4b5 May 15, 2015
mtbrandy pushed a commit to ibmsoe/spark that referenced this pull request May 18, 2015
Fix more places in which some test variables could be collected early by aggressive JVM optimization.
Added a couple of comments to note where existing references are sufficient in the same test pattern.

Author: Tim Ellison <[email protected]>

Closes apache#6187 from tellison/DefeatEarlyGC and squashes the following commits:

27329d9 [Tim Ellison] [CORE] Protect additional test vars from early GC

(cherry picked from commit 270d4b5)
Signed-off-by: Andrew Or <[email protected]>

Conflicts:
	core/src/test/scala/org/apache/spark/ContextCleanerSuite.scala
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request May 28, 2015
Fix more places in which some test variables could be collected early by aggressive JVM optimization.
Added a couple of comments to note where existing references are sufficient in the same test pattern.

Author: Tim Ellison <[email protected]>

Closes apache#6187 from tellison/DefeatEarlyGC and squashes the following commits:

27329d9 [Tim Ellison] [CORE] Protect additional test vars from early GC
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request Jun 12, 2015
Fix more places in which some test variables could be collected early by aggressive JVM optimization.
Added a couple of comments to note where existing references are sufficient in the same test pattern.

Author: Tim Ellison <[email protected]>

Closes apache#6187 from tellison/DefeatEarlyGC and squashes the following commits:

27329d9 [Tim Ellison] [CORE] Protect additional test vars from early GC
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
Fix more places in which some test variables could be collected early by aggressive JVM optimization.
Added a couple of comments to note where existing references are sufficient in the same test pattern.

Author: Tim Ellison <[email protected]>

Closes apache#6187 from tellison/DefeatEarlyGC and squashes the following commits:

27329d9 [Tim Ellison] [CORE] Protect additional test vars from early GC
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants