Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-7752][MLLIB] Use lowercase letters for NaiveBayes.modelType #6277

Closed
wants to merge 7 commits into from
Closed

[SPARK-7752][MLLIB] Use lowercase letters for NaiveBayes.modelType #6277

wants to merge 7 commits into from

Conversation

mengxr
Copy link
Contributor

@mengxr mengxr commented May 20, 2015

to be consistent with other string names in MLlib. This PR also updates the implementation to use vals instead of hardcoded strings. @jkbradley @leahmcguire

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@SparkQA
Copy link

SparkQA commented May 20, 2015

Test build #33128 has started for PR 6277 at commit 264a814.

@SparkQA
Copy link

SparkQA commented May 20, 2015

Test build #33128 has finished for PR 6277 at commit 264a814.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • s" but class priors vector pi had $
    • s" but class conditionals array theta had $

@AmplabJenkins
Copy link

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33128/
Test FAILed.

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@SparkQA
Copy link

SparkQA commented May 20, 2015

Test build #33137 has started for PR 6277 at commit 40ae53e.

@SparkQA
Copy link

SparkQA commented May 20, 2015

Test build #33137 has finished for PR 6277 at commit 40ae53e.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • s" but class priors vector pi had $
    • s" but class conditionals array theta had $

@AmplabJenkins
Copy link

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33137/
Test FAILed.

@mengxr
Copy link
Contributor Author

mengxr commented May 20, 2015

test this please

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@SparkQA
Copy link

SparkQA commented May 20, 2015

Test build #33145 has started for PR 6277 at commit 40ae53e.

@SparkQA
Copy link

SparkQA commented May 20, 2015

Test build #33145 has finished for PR 6277 at commit 40ae53e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • s" but class priors vector pi had $
    • s" but class conditionals array theta had $

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33145/
Test PASSed.

jkbradley
jkbradley reviewed May 20, 2015
View reviewed changes
mllib/src/main/scala/org/apache/spark/mllib/classification/NaiveBayes.scala

def this() = this(1.0, "Multinomial")
def this(lambda: Double) = this(lambda, NaiveBayes.Multinomial)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"NaiveBayes.Multinomial" --> "Multinomial"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't compile, because this(...) is not in the scope of NaiveBayes.

@jkbradley
Copy link
Member

Looks fine other than those small comments

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@SparkQA
Copy link

SparkQA commented May 21, 2015

Test build #33209 has started for PR 6277 at commit f38b662.

@SparkQA
Copy link

SparkQA commented May 21, 2015

Test build #33209 has finished for PR 6277 at commit f38b662.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33209/
Test PASSed.

@jkbradley
Copy link
Member

LGTM

@jkbradley
Copy link
Member

Merging with master and branch-1.4

asfgit pushed a commit that referenced this pull request May 21, 2015
@mengxr @jkbradley
[SPARK-7752] [MLLIB] Use lowercase letters for NaiveBayes.modelType
b97a805 
to be consistent with other string names in MLlib. This PR also updates the implementation to use vals instead of hardcoded strings. jkbradley leahmcguire

Author: Xiangrui Meng <[email protected]>

Closes #6277 from mengxr/SPARK-7752 and squashes the following commits:

f38b662 [Xiangrui Meng] add another case _ back in test
ae5c66a [Xiangrui Meng] model type -> modelType
711d1c6 [Xiangrui Meng] Merge remote-tracking branch 'apache/master' into SPARK-7752
40ae53e [Xiangrui Meng] fix Java test suite
264a814 [Xiangrui Meng] add case _ back
3c456a8 [Xiangrui Meng] update NB user guide
17bba53 [Xiangrui Meng] update naive Bayes to use lowercase model type strings

(cherry picked from commit 13348e2)
Signed-off-by: Joseph K. Bradley <[email protected]>
@asfgit asfgit closed this in 13348e2 May 21, 2015
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request May 28, 2015
@mengxr @jeanlyn
[SPARK-7752] [MLLIB] Use lowercase letters for NaiveBayes.modelType
75f03cb 
to be consistent with other string names in MLlib. This PR also updates the implementation to use vals instead of hardcoded strings. jkbradley leahmcguire

Author: Xiangrui Meng <[email protected]>

Closes apache#6277 from mengxr/SPARK-7752 and squashes the following commits:

f38b662 [Xiangrui Meng] add another case _ back in test
ae5c66a [Xiangrui Meng] model type -> modelType
711d1c6 [Xiangrui Meng] Merge remote-tracking branch 'apache/master' into SPARK-7752
40ae53e [Xiangrui Meng] fix Java test suite
264a814 [Xiangrui Meng] add case _ back
3c456a8 [Xiangrui Meng] update NB user guide
17bba53 [Xiangrui Meng] update naive Bayes to use lowercase model type strings
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request Jun 12, 2015
@mengxr @jeanlyn
[SPARK-7752] [MLLIB] Use lowercase letters for NaiveBayes.modelType
737fa8d 
to be consistent with other string names in MLlib. This PR also updates the implementation to use vals instead of hardcoded strings. jkbradley leahmcguire

Author: Xiangrui Meng <[email protected]>

Closes apache#6277 from mengxr/SPARK-7752 and squashes the following commits:

f38b662 [Xiangrui Meng] add another case _ back in test
ae5c66a [Xiangrui Meng] model type -> modelType
711d1c6 [Xiangrui Meng] Merge remote-tracking branch 'apache/master' into SPARK-7752
40ae53e [Xiangrui Meng] fix Java test suite
264a814 [Xiangrui Meng] add case _ back
3c456a8 [Xiangrui Meng] update NB user guide
17bba53 [Xiangrui Meng] update naive Bayes to use lowercase model type strings
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
@mengxr @nemccarthy
[SPARK-7752] [MLLIB] Use lowercase letters for NaiveBayes.modelType
4193baf 
to be consistent with other string names in MLlib. This PR also updates the implementation to use vals instead of hardcoded strings. jkbradley leahmcguire

Author: Xiangrui Meng <[email protected]>

Closes apache#6277 from mengxr/SPARK-7752 and squashes the following commits:

f38b662 [Xiangrui Meng] add another case _ back in test
ae5c66a [Xiangrui Meng] model type -> modelType
711d1c6 [Xiangrui Meng] Merge remote-tracking branch 'apache/master' into SPARK-7752
40ae53e [Xiangrui Meng] fix Java test suite
264a814 [Xiangrui Meng] add case _ back
3c456a8 [Xiangrui Meng] update NB user guide
17bba53 [Xiangrui Meng] update naive Bayes to use lowercase model type strings
@steveloughran steveloughran mentioned this pull request Jan 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mengxr @AmplabJenkins @SparkQA @jkbradley