Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-7801] [BUILD] Updating versions to SPARK 1.5.0 #6328

Closed
wants to merge 6 commits into from
Closed

[SPARK-7801] [BUILD] Updating versions to SPARK 1.5.0 #6328

wants to merge 6 commits into from

Conversation

pwendell
Copy link
Contributor

No description provided.

@pwendell
Copy link
Contributor Author

Jenkins, test this please.

@SparkQA
Copy link

SparkQA commented May 21, 2015

Test build #33271 has finished for PR 6328 at commit 42d765a.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • s" but class priors vector pi had $
    • s" but class conditionals array theta had $

@pwendell pwendell force-pushed the spark-1.5-update branch from 42d765a to cdb4fca Compare May 21, 2015 20:01
@SparkQA
Copy link

SparkQA commented May 21, 2015

Test build #33273 has finished for PR 6328 at commit cdb4fca.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • s" but class priors vector pi had $
    • s" but class conditionals array theta had $

@pwendell pwendell force-pushed the spark-1.5-update branch from cdb4fca to b758c52 Compare May 21, 2015 21:37
@pwendell
Copy link
Contributor Author

Jenkins, test this please.

@SparkQA
Copy link

SparkQA commented May 21, 2015

Test build #33288 has finished for PR 6328 at commit b758c52.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@pwendell pwendell force-pushed the spark-1.5-update branch from b758c52 to 36f549b Compare May 21, 2015 22:25
@pwendell
Copy link
Contributor Author

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented May 21, 2015

Test build #33294 has finished for PR 6328 at commit 36f549b.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • s" but class priors vector pi had $
    • s" but class conditionals array theta had $

@pwendell
Copy link
Contributor Author

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented May 22, 2015

Test build #33299 timed out for PR 6328 at commit 04b4f04 after a configured wait of 150m.

@pwendell
Copy link
Contributor Author

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented May 22, 2015

Test build #33330 has finished for PR 6328 at commit 04b4f04.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@pwendell
Copy link
Contributor Author

Jenkins, test this please.

@SparkQA
Copy link

SparkQA commented May 22, 2015

Test build #33335 has finished for PR 6328 at commit 55f1610.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented May 24, 2015

Test build #33429 has finished for PR 6328 at commit 61aaf46.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@pwendell
Copy link
Contributor Author

This is a pretty straightforward change so I'm just going to pull it in.

@pwendell
Copy link
Contributor Author

Jenkins, retest this please (actually one more just to make sure MIMA is still passing)

@SparkQA
Copy link

SparkQA commented May 24, 2015

Test build #33456 has finished for PR 6328 at commit 61aaf46.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@vanzin
Copy link
Contributor

vanzin commented Jun 3, 2015

@pwendell any update on this? It would be nice to get into the custom of updating the master version early (usually when the release branch is created).

@pwendell
Copy link
Contributor Author

pwendell commented Jun 3, 2015

@vanzin just updated to the newest RC. I kept racing with changes that were getting back-ported, so I gave up until the branch stabilized a bit.

We can do it earlier but then it becomes a burden for all new patches, since anything that does a refactoring in a way that removes API's (even from RCX -> RC[X + 1]) has to add a MIMA exception. It turns out we do this kind of often.

@pwendell
Copy link
Contributor Author

pwendell commented Jun 3, 2015

BTW - this is also important to do soon because of the fact that we publish snapshot releases now from both master and 1.4 branches.

@SparkQA
Copy link

SparkQA commented Jun 3, 2015

Test build #34059 has finished for PR 6328 at commit 4bebcf0.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@pwendell
Copy link
Contributor Author

pwendell commented Jun 3, 2015

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Jun 3, 2015

Test build #34065 has finished for PR 6328 at commit 3bec7b9.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@pwendell pwendell force-pushed the spark-1.5-update branch from 3bec7b9 to 2f42d02 Compare June 3, 2015 05:57
@SparkQA
Copy link

SparkQA commented Jun 3, 2015

Test build #34068 has finished for PR 6328 at commit 2f42d02.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Jun 3, 2015

Jenkins, retest this please

@SparkQA
Copy link

SparkQA commented Jun 3, 2015

Test build #34082 has finished for PR 6328 at commit 2f42d02.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

vanzin
vanzin reviewed Jun 3, 2015
View reviewed changes
project/MimaExcludes.scala
MimaBuild.excludeSparkPackage("deploy"),
// These are needed if checking against the sbt build, since they are part of
// the maven-generated artifacts in 1.3.
excludePackage("org.spark-project.jetty"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this is strictly needed since 1.4 has the shaded jetty already, but doesn't hurt either.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was actually failing before I added it. Probably worth digging into, but given all the races with this patch I am inclined to maybe merge this in now and then worry about it later.

@vanzin
Copy link
Contributor

vanzin commented Jun 3, 2015

LGTM.

@asfgit asfgit closed this in 2c4d550 Jun 3, 2015
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request Jun 12, 2015
@pwendell @jeanlyn
[SPARK-7801] [BUILD] Updating versions to SPARK 1.5.0
b600104 
Author: Patrick Wendell <[email protected]>

Closes apache#6328 from pwendell/spark-1.5-update and squashes the following commits:

2f42d02 [Patrick Wendell] A few more excludes
4bebcf0 [Patrick Wendell] Update to RC4
61aaf46 [Patrick Wendell] Using new release candidate
55f1610 [Patrick Wendell] Another exclude
04b4f04 [Patrick Wendell] More issues with transient 1.4 changes
36f549b [Patrick Wendell] [SPARK-7801] [BUILD] Updating versions to SPARK 1.5.0
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
@pwendell @nemccarthy
[SPARK-7801] [BUILD] Updating versions to SPARK 1.5.0
d7aa755 
Author: Patrick Wendell <[email protected]>

Closes apache#6328 from pwendell/spark-1.5-update and squashes the following commits:

2f42d02 [Patrick Wendell] A few more excludes
4bebcf0 [Patrick Wendell] Update to RC4
61aaf46 [Patrick Wendell] Using new release candidate
55f1610 [Patrick Wendell] Another exclude
04b4f04 [Patrick Wendell] More issues with transient 1.4 changes
36f549b [Patrick Wendell] [SPARK-7801] [BUILD] Updating versions to SPARK 1.5.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pwendell @SparkQA @vanzin @srowen