Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR] [CORE] Warn about caching if dynamic allocation is enabled (1.3) #6421

Closed
wants to merge 1 commit into from

Conversation

andrewor14
Copy link
Contributor

This is a resubmit of #5751 for branch-1.3. The previous cherry-pick caused a build break that was later reverted. Originally written by @vanzin.

@vanzin
Copy link
Contributor

vanzin commented May 26, 2015

LGTM.

@SparkQA
Copy link

SparkQA commented May 26, 2015

Test build #33544 has finished for PR 6421 at commit 25cbb53.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@andrewor14
Copy link
Contributor Author

retest this please

@SparkQA
Copy link

SparkQA commented May 27, 2015

Test build #33553 has finished for PR 6421 at commit 25cbb53.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@andrewor14
Copy link
Contributor Author

wow, same test failure. retest this please

@SparkQA
Copy link

SparkQA commented May 27, 2015

Test build #33561 has finished for PR 6421 at commit 25cbb53.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@andrewor14
Copy link
Contributor Author

SparkSubmitSuite is out of control. retest this please

@SparkQA
Copy link

SparkQA commented May 27, 2015

Test build #33602 has finished for PR 6421 at commit 25cbb53.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@andrewor14
Copy link
Contributor Author

retest this please

@SparkQA
Copy link

SparkQA commented May 28, 2015

Test build #33647 has finished for PR 6421 at commit 25cbb53.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@andrewor14
Copy link
Contributor Author

Ugh. Merged.

asfgit pushed a commit that referenced this pull request May 28, 2015
This is a resubmit of #5751 for branch-1.3. The previous cherry-pick caused a build break that was later [reverted](2254576). Originally written by vanzin.

Author: Andrew Or <[email protected]>

Closes #6421 from andrewor14/warn-da-cache-1.3 and squashes the following commits:

25cbb53 [Andrew Or] If DA is enabled, warn about caching
@andrewor14 andrewor14 closed this May 28, 2015
@andrewor14 andrewor14 deleted the warn-da-cache-1.3 branch May 28, 2015 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants