Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-8054] [mllib] Added several Java-friendly APIs + unit tests #6562

Closed
wants to merge 4 commits into from

Conversation

jkbradley
Copy link
Member

Java-friendly APIs added:

  • GaussianMixture.run()
  • GaussianMixtureModel.predict()
  • DistributedLDAModel.javaTopicDistributions()
  • StreamingKMeans: trainOn, predictOn, predictOnValues
  • Statistics.corr
  • params
    • added doc to w() since Java docs do not inherit doc
    • removed non-Java-friendly w() from StringArrayParam and DoubleArrayParam
    • made DoubleArrayParam Java-friendly w() actually Java-friendly

I generated the doc and verified all changes.

CC: @mengxr

@SparkQA
Copy link

SparkQA commented Jun 1, 2015

Test build #33926 has finished for PR 6562 at commit 29b6b0d.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jun 2, 2015

Test build #33941 has finished for PR 6562 at commit d955581.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jkbradley
Copy link
Member Author

test this please

@SparkQA
Copy link

SparkQA commented Jun 2, 2015

Test build #33952 has finished for PR 6562 at commit d955581.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@@ -190,6 +186,7 @@ class DoubleParam(parent: String, name: String, doc: String, isValid: Double =>

def this(parent: Identifiable, name: String, doc: String) = this(parent.uid, name, doc)

/** Creates a param pair with the given value (for Java). */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, it doesn't inherit the parent doc.

@mengxr
Copy link
Contributor

mengxr commented Jun 2, 2015

LGTM pending Jenkins.

@SparkQA
Copy link

SparkQA commented Jun 2, 2015

Test build #34005 has finished for PR 6562 at commit c16821b.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jkbradley
Copy link
Member Author

streaming failure

@SparkQA
Copy link

SparkQA commented Jun 2, 2015

Test build #872 has finished for PR 6562 at commit c16821b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jkbradley jkbradley changed the title [SPARK-7529] [mllib] Added several Java-friendly APIs + unit tests [SPARK-8054] [mllib] Added several Java-friendly APIs + unit tests Jun 2, 2015
@jkbradley
Copy link
Member Author

I'll merge this with master

@jkbradley
Copy link
Member Author

Nevermind, I'll just wait until 1.4 is out so that I can then include it for 1.4.1

@mengxr
Copy link
Contributor

mengxr commented Jun 3, 2015

@jkbradley If we want to include it in 1.4.1, we can merge it into branch-1.4 now and set the fix version to 1.4.1 and 1.5.0. If RC4 doesn't pass the vote, @pwendell will find those JIRAs and set the fix version back to 1.4.0.

@jkbradley
Copy link
Member Author

Oh OK sounds good. I'll merge it with master and branch-1.4 then

asfgit pushed a commit that referenced this pull request Jun 3, 2015
Java-friendly APIs added:
* GaussianMixture.run()
* GaussianMixtureModel.predict()
* DistributedLDAModel.javaTopicDistributions()
* StreamingKMeans: trainOn, predictOn, predictOnValues
* Statistics.corr
* params
  * added doc to w() since Java docs do not inherit doc
  * removed non-Java-friendly w() from StringArrayParam and DoubleArrayParam
  * made DoubleArrayParam Java-friendly w() actually Java-friendly

I generated the doc and verified all changes.

CC: mengxr

Author: Joseph K. Bradley <[email protected]>

Closes #6562 from jkbradley/java-api-1.4 and squashes the following commits:

c16821b [Joseph K. Bradley] Small fixes based on code review.
d955581 [Joseph K. Bradley] unit test fixes
29b6b0d [Joseph K. Bradley] small fixes
fe6dcfe [Joseph K. Bradley] Added several Java-friendly APIs + unit tests: NaiveBayes, GaussianMixture, LDA, StreamingKMeans, Statistics.corr, params

(cherry picked from commit 20a26b5)
Signed-off-by: Joseph K. Bradley <[email protected]>
@asfgit asfgit closed this in 20a26b5 Jun 3, 2015
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request Jun 12, 2015
Java-friendly APIs added:
* GaussianMixture.run()
* GaussianMixtureModel.predict()
* DistributedLDAModel.javaTopicDistributions()
* StreamingKMeans: trainOn, predictOn, predictOnValues
* Statistics.corr
* params
  * added doc to w() since Java docs do not inherit doc
  * removed non-Java-friendly w() from StringArrayParam and DoubleArrayParam
  * made DoubleArrayParam Java-friendly w() actually Java-friendly

I generated the doc and verified all changes.

CC: mengxr

Author: Joseph K. Bradley <[email protected]>

Closes apache#6562 from jkbradley/java-api-1.4 and squashes the following commits:

c16821b [Joseph K. Bradley] Small fixes based on code review.
d955581 [Joseph K. Bradley] unit test fixes
29b6b0d [Joseph K. Bradley] small fixes
fe6dcfe [Joseph K. Bradley] Added several Java-friendly APIs + unit tests: NaiveBayes, GaussianMixture, LDA, StreamingKMeans, Statistics.corr, params
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
Java-friendly APIs added:
* GaussianMixture.run()
* GaussianMixtureModel.predict()
* DistributedLDAModel.javaTopicDistributions()
* StreamingKMeans: trainOn, predictOn, predictOnValues
* Statistics.corr
* params
  * added doc to w() since Java docs do not inherit doc
  * removed non-Java-friendly w() from StringArrayParam and DoubleArrayParam
  * made DoubleArrayParam Java-friendly w() actually Java-friendly

I generated the doc and verified all changes.

CC: mengxr

Author: Joseph K. Bradley <[email protected]>

Closes apache#6562 from jkbradley/java-api-1.4 and squashes the following commits:

c16821b [Joseph K. Bradley] Small fixes based on code review.
d955581 [Joseph K. Bradley] unit test fixes
29b6b0d [Joseph K. Bradley] small fixes
fe6dcfe [Joseph K. Bradley] Added several Java-friendly APIs + unit tests: NaiveBayes, GaussianMixture, LDA, StreamingKMeans, Statistics.corr, params
@jkbradley jkbradley deleted the java-api-1.4 branch July 25, 2016 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants