Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-7980] [SQL] Support SQLContext.range(end) #6609

Closed
wants to merge 1 commit into from
Closed

[SPARK-7980] [SQL] Support SQLContext.range(end) #6609

wants to merge 1 commit into from

Conversation

animeshbaranawal
Copy link

  1. range() overloaded in SQLContext.scala
  2. range() modified in python sql context.py
  3. Tests added accordingly in DataFrameSuite.scala and python sql tests.py

@rxin
Copy link
Contributor

rxin commented Jun 3, 2015

Jenkins, ok to test.

@SparkQA
Copy link

SparkQA commented Jun 3, 2015

Test build #34080 has finished for PR 6609 at commit 935899c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class ElementwiseProduct(val scalingVec: Vector) extends VectorTransformer

rxin
rxin reviewed Jun 3, 2015
View reviewed changes
python/pyspark/sql/context.py
@@ -128,7 +128,7 @@ def udf(self):
return UDFRegistration(self)

@since(1.4)
def range(self, start, end, step=1, numPartitions=None):
def range(self, start, end=None, step=1, numPartitions=None):
"""
Create a :class:`DataFrame` with single LongType column named `id`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should document the behavior when only start is declared.

@rxin
Copy link
Contributor

rxin commented Jun 3, 2015

I'm going to merge it and fix the documentation myself. Thanks.

@asfgit asfgit closed this in d053a31 Jun 3, 2015
asfgit pushed a commit that referenced this pull request Jun 3, 2015
@rxin
[SPARK-7980] [SQL] Support SQLContext.range(end)
0a1dad6 
1. range() overloaded in SQLContext.scala
2. range() modified in python sql context.py
3. Tests added accordingly in DataFrameSuite.scala and python sql tests.py

Author: animesh <[email protected]>

Closes #6609 from animeshbaranawal/SPARK-7980 and squashes the following commits:

935899c [animesh] SPARK-7980:python+scala changes

(cherry picked from commit d053a31)
Signed-off-by: Reynold Xin <[email protected]>
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request Jun 12, 2015
@jeanlyn
[SPARK-7980] [SQL] Support SQLContext.range(end)
daeda20 
1. range() overloaded in SQLContext.scala
2. range() modified in python sql context.py
3. Tests added accordingly in DataFrameSuite.scala and python sql tests.py

Author: animesh <[email protected]>

Closes apache#6609 from animeshbaranawal/SPARK-7980 and squashes the following commits:

935899c [animesh] SPARK-7980:python+scala changes
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
@nemccarthy
[SPARK-7980] [SQL] Support SQLContext.range(end)
288d8ae 
1. range() overloaded in SQLContext.scala
2. range() modified in python sql context.py
3. Tests added accordingly in DataFrameSuite.scala and python sql tests.py

Author: animesh <[email protected]>

Closes apache#6609 from animeshbaranawal/SPARK-7980 and squashes the following commits:

935899c [animesh] SPARK-7980:python+scala changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@animeshbaranawal @rxin @SparkQA