[SPARKR][SPARK-8452] expose jobGroup API in SparkR #6889
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #' @param interruptOnCancel flag to indicate if the job is interrupted on job cancellation | ||
|
|
||
| setJobGroup <- function(groupId, description, interruptOnCancel) { | ||
| if (exists(".sparkRjsc", envir = env)) { |
There was a problem hiding this comment.
While its technically fine to just lookup the SparkContext I think all our methods take in a SQLContext / SparkContext explicitly. Will that work for your use case as well ?
There was a problem hiding this comment.
Yes, that is perfectly fine. Just wondering why doesn't sparkR.stop() follow that convention?
|
Test build #35181 has finished for PR 6889 at commit
|
|
Test build #35193 has finished for PR 6889 at commit
|
|
LGTM, it will be better if you could add some tests for it, and add examples in the doc. Right now it's hard to tell what's the type of these parameters. |
| #' @param sc existing spark context | ||
| #' @param groupid the ID to be assigned to job groups | ||
| #' @param description description for the the job group ID | ||
| #' @param interruptOnCancel flag to indicate if the job is interrupted on job cancellation |
There was a problem hiding this comment.
Yeah @davies point is a good one. We can add an example usage here with something like
#' @examples
#'\dontrun{
#' sc <- sparkR.init()
# setJobGroup(sc, "group", "some group", TRUE)
#'}
|
LGTM, waiting for tests. |
|
Test build #35316 has finished for PR 6889 at commit
|
|
Thanks @falaki -- Merging this |
asfgit
pushed a commit
that referenced
this pull request
Jun 19, 2015
This pull request adds following methods to SparkR: ```R setJobGroup() cancelJobGroup() clearJobGroup() ``` For each method, the spark context is passed as the first argument. There does not seem to be a good way to test these in R. cc shivaram and davies Author: Hossein <[email protected]> Closes #6889 from falaki/SPARK-8452 and squashes the following commits: 9ce9f1e [Hossein] Added basic tests to verify methods can be called and won't throw errors c706af9 [Hossein] Added examples a2c19af [Hossein] taking spark context as first argument 343ca77 [Hossein] Added setJobGroup, cancelJobGroup and clearJobGroup to SparkR (cherry picked from commit 1fa29c2) Signed-off-by: Shivaram Venkataraman <[email protected]>
nemccarthy
pushed a commit
to nemccarthy/spark
that referenced
this pull request
Jun 22, 2015
This pull request adds following methods to SparkR: ```R setJobGroup() cancelJobGroup() clearJobGroup() ``` For each method, the spark context is passed as the first argument. There does not seem to be a good way to test these in R. cc shivaram and davies Author: Hossein <[email protected]> Closes apache#6889 from falaki/SPARK-8452 and squashes the following commits: 9ce9f1e [Hossein] Added basic tests to verify methods can be called and won't throw errors c706af9 [Hossein] Added examples a2c19af [Hossein] taking spark context as first argument 343ca77 [Hossein] Added setJobGroup, cancelJobGroup and clearJobGroup to SparkR (cherry picked from commit 1fa29c2) Signed-off-by: Shivaram Venkataraman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds following methods to SparkR:
For each method, the spark context is passed as the first argument. There does not seem to be a good way to test these in R.
cc @shivaram and @davies