Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-8476] [CORE] Setters inc/decDiskBytesSpilled in TaskMetrics should also be private. #6896

Closed
wants to merge 1 commit into from

Conversation

ueshin
Copy link
Member

@ueshin ueshin commented Jun 19, 2015

This is a follow-up of SPARK-3288.

@SparkQA
Copy link

SparkQA commented Jun 19, 2015

Test build #35222 has finished for PR 6896 at commit 89251d8.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class SerializableConfiguration(@transient var value: Configuration) extends Serializable
    • class SerializableJobConf(@transient var value: JobConf) extends Serializable

@srowen
Copy link
Member

srowen commented Jun 19, 2015

It's a developer API, but is it worth hiding at this point? does it cause problems?

@ueshin
Copy link
Member Author

ueshin commented Jun 19, 2015

@srowen, Thank you for your comment.
Yes, it's a developer API for getters, but I think setters should not open for developers like other setters of this class because if they are open, task metrics might be overwritten by developers.

@srowen
Copy link
Member

srowen commented Jun 19, 2015

A lot of similar stuff was done in 1.3 in SPARK-3288: 3453d57

Seems consistent, yeah. @rxin are you OK with it? just because you committed this particular line last.

@rxin
Copy link
Contributor

rxin commented Jun 19, 2015

LGTM. Merging. Thanks!

@asfgit asfgit closed this in fe08561 Jun 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants