Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-8495][SparkR] Add a .lintr file to validate the SparkR files and the lint-r script #6922

Closed
wants to merge 3 commits into from
Closed

[SPARK-8495][SparkR] Add a .lintr file to validate the SparkR files and the lint-r script #6922

wants to merge 3 commits into from

Conversation

yu-iskw
Copy link
Contributor

@yu-iskw yu-iskw commented Jun 20, 2015

Thank Shivaram Venkataraman for your support. This is a prototype script to validate the R files.

@yu-iskw
[SPARK-8495][SparkR] Add a .lintr file to validate the SparkR files…
8f94680 
… and the `lint-r` script

Thank Shivaram Venkataraman for your support. This is a prototype script
to validate the R files.
@yu-iskw
Copy link
Contributor Author

yu-iskw commented Jun 20, 2015

@shivaram Could you review it when you have time? Thanks!

@SparkQA
Copy link

SparkQA commented Jun 20, 2015

Test build #35366 has finished for PR 6922 at commit 8f94680.

  • This patch fails RAT tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

shivaram
shivaram reviewed Jun 20, 2015
View reviewed changes
dev/lint-r
exit
fi

`which Rscript` --vanilla "$SPARK_ROOT_DIR/dev/lint-r.R" "$SPARK_ROOT_DIR"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also save the output of this to a file so that users can see the report after the script exits ? The lint-python script does something similar

@yu-iskw
Copy link
Contributor Author

yu-iskw commented Jun 20, 2015

@shivaram Thank you for your feedback.

  • save the result to a log file
  • Add the rule to the .lintr file

@SparkQA
Copy link

SparkQA commented Jun 20, 2015

Test build #35367 has finished for PR 6922 at commit 5520806.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jun 20, 2015

Test build #35370 has finished for PR 6922 at commit c1ffe6b.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@yu-iskw
Copy link
Contributor Author

yu-iskw commented Jun 20, 2015

Jenkins, test this please.

@SparkQA
Copy link

SparkQA commented Jun 20, 2015

Test build #35371 has finished for PR 6922 at commit c1ffe6b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@shivaram
Copy link
Contributor

LGTM. Thanks @yu-iskw -- BTW we should fix the existing style issues before turning it on for Jenkins but lets discuss more on the JIRA for this.

@asfgit asfgit closed this in 004f573 Jun 20, 2015
@yu-iskw
Copy link
Contributor Author

yu-iskw commented Jun 20, 2015

@shivaram Thank you for reviewing! I agree with you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yu-iskw @SparkQA @shivaram