Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SQL][Docs] updated the documentation for explode #6943

Closed
wants to merge 1 commit into from

Conversation

lockwobr
Copy link
Contributor

the syntax was incorrect in the example in explode

the syntax was incorrect in the example in explode
@sarutak
Copy link
Member

sarutak commented Jun 23, 2015

ok to test.

@sarutak
Copy link
Member

sarutak commented Jun 23, 2015

LGTM. Pending Jenkins.

@rxin
Copy link
Contributor

rxin commented Jun 23, 2015

Jenkins, ok to test.

@SparkQA
Copy link

SparkQA commented Jun 23, 2015

Test build #35519 has finished for PR 6943 at commit 3d864d1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Jun 23, 2015

Does ...(_.split(" ")) work here too? not sure, ignore me if it can't be written that way.
Ideally put [DOCS] in the title please, but this may yet be something trivial enough to not need a JIRA. Please review https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark
@sarutak I think you can try out merging when you're ready

@lockwobr
Copy link
Contributor Author

@srowen
Well it can kind of work that way if you type it like this (below) not sure what style spark community prefers, left it more closer to the original documentation.

df.explode[String, String]("words", "word"){_.split(" ")}

I didn't think that I needed a JIRA ticket. The JIRA the documentation stated "However, trivial changes, where the what should change is virtually the same as the how it should change do not require a JIRA. Example: "Fix typos in Foo scaladoc""

So in the future I should put the [Docs] in the pull request? Is that what you meant?

@srowen
Copy link
Member

srowen commented Jun 23, 2015

Yes, seems OK to me. Just put [DOCS] in the title, still, as a matter of practice.

@lockwobr lockwobr changed the title updated the documentation for explode [SQL][Docs] updated the documentation for explode Jun 23, 2015
@asfgit asfgit closed this in 4f7fbef Jun 23, 2015
asfgit pushed a commit that referenced this pull request Jun 23, 2015
the syntax was incorrect in the example in explode

Author: lockwobr <[email protected]>

Closes #6943 from lockwobr/master and squashes the following commits:

3d864d1 [lockwobr] updated the documentation for explode

(cherry picked from commit 4f7fbef)
Signed-off-by: Kousuke Saruta <[email protected]>
@sarutak
Copy link
Member

sarutak commented Jun 23, 2015

Thanks @lockwobr ! Merged this to master and branch-1.4.
Thanks @rxin , @srowen for your assist!

nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 25, 2015
the syntax was incorrect in the example in explode

Author: lockwobr <[email protected]>

Closes apache#6943 from lockwobr/master and squashes the following commits:

3d864d1 [lockwobr] updated the documentation for explode

(cherry picked from commit 4f7fbef)
Signed-off-by: Kousuke Saruta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants