Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-8567] [SQL] Increase the timeout of HiveSparkSubmitSuite #6957

Closed
wants to merge 1 commit into from
Closed

[SPARK-8567] [SQL] Increase the timeout of HiveSparkSubmitSuite #6957

wants to merge 1 commit into from

Conversation

yhuai
Copy link
Contributor

@yhuai yhuai commented Jun 23, 2015

@SparkQA
Copy link

SparkQA commented Jun 23, 2015

Test build #35567 has finished for PR 6957 at commit f8aab7f.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@JoshRosen
Copy link
Contributor

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Jun 23, 2015

Test build #35572 has finished for PR 6957 at commit f8aab7f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@yhuai
Copy link
Contributor Author

yhuai commented Jun 23, 2015

hmm... Jenkins still does not have the logs of applications launched in HiveSparkSubmitSuite.

@JoshRosen
Copy link
Contributor

@yhuai, where are those logs written when you run the tests locally? We might have to add those log paths to the list that Jenkins checks when attaching build artifacts in the post-build step.

@yhuai
Copy link
Contributor Author

yhuai commented Jun 23, 2015

They are in sql/hive/target/uni-tests.log. The log in jenkins only shows

12:47:58.306 pool-1-thread-1-ScalaTest-running-HiveSparkSubmitSuite INFO HiveSparkSubmitSuite: 

===== TEST OUTPUT FOR o.a.s.sql.hive.HiveSparkSubmitSuite: 'SPARK-8368: includes jars passed in through --jars' =====

12:49:04.038 pool-1-thread-1-ScalaTest-running-HiveSparkSubmitSuite INFO HiveSparkSubmitSuite: 

===== FINISHED o.a.s.sql.hive.HiveSparkSubmitSuite: 'SPARK-8368: includes jars passed in through --jars' =====

12:49:04.039 pool-1-thread-1-ScalaTest-running-HiveSparkSubmitSuite INFO HiveSparkSubmitSuite: 

===== TEST OUTPUT FOR o.a.s.sql.hive.HiveSparkSubmitSuite: 'SPARK-8020: set sql conf in spark conf' =====

12:49:52.939 pool-1-thread-1-ScalaTest-running-HiveSparkSubmitSuite INFO HiveSparkSubmitSuite: 

===== FINISHED o.a.s.sql.hive.HiveSparkSubmitSuite: 'SPARK-8020: set sql conf in spark conf' =====

12:49:52.941 pool-1-thread-1-ScalaTest-running-HiveSparkSubmitSuite INFO HiveSparkSubmitSuite: 

===== TEST OUTPUT FOR o.a.s.sql.hive.HiveSparkSubmitSuite: 'SPARK-8489: MissingRequirementError during reflection' =====

12:50:42.262 pool-1-thread-1-ScalaTest-running-HiveSparkSubmitSuite INFO HiveSparkSubmitSuite: 

===== FINISHED o.a.s.sql.hive.HiveSparkSubmitSuite: 'SPARK-8489: MissingRequirementError during reflection' =====

@andrewor14
Copy link
Contributor

I just ran this locally and my sql/hive/target/unit-test.logs looks different. Looks like they are logged to the right file there.

===== TEST OUTPUT FOR o.a.s.sql.hive.HiveSparkSubmitSuite: 'SPARK-8368: includes jars passed in through --jars' ===== 

14:21:43.037 pool-1-thread-1-ScalaTest-running-HiveSparkSubmitSuite INFO SparkContext: Running Spark version 1.5.0-SNAPSHOT
14:21:43.074 pool-1-thread-1-ScalaTest-running-HiveSparkSubmitSuite DEBUG MutableMetricsFactory: field org.apache.hadoop.metrics2.lib.MutableRate org.apache.hadoop.security.UserGroupInformation$UgiMetrics.loginSuccess with annotation @org.apache.hadoop.metrics2.annotation.Metric(valueName=Time, about=, value=[Rate of successful kerberos logins and latency (milliseconds)], always=false, type=DEFAULT, sampleName=Ops)
14:21:43.078 pool-1-thread-1-ScalaTest-running-HiveSparkSubmitSuite DEBUG MutableMetricsFactory: field org.apache.hadoop.metrics2.lib.MutableRate org.apache.hadoop.security.UserGroupInformation$UgiMetrics.loginFailure with annotation @org.apache.hadoop.metrics2.annotation.Metric(valueName=Time, about=, value=[Rate of failed kerberos logins and latency (milliseconds)], always=false, type=DEFAULT, sampleName=Ops)
14:21:43.078 pool-1-thread-1-ScalaTest-running-HiveSparkSubmitSuite DEBUG MetricsSystemImpl: UgiMetrics, User and group related metrics
14:21:43.305 pool-1-thread-1-ScalaTest-running-HiveSparkSubmitSuite DEBUG KerberosName: Kerberos krb5 configuration not found, setting default realm to empty 
14:21:43.307 pool-1-thread-1-ScalaTest-running-HiveSparkSubmitSuite DEBUG Groups:  Creating new Groups object
...

@yhuai
Copy link
Contributor Author

yhuai commented Jun 23, 2015

@andrewor14 Yeah, I also got that in my laptop.

@liancheng
Copy link
Contributor

Partly reproduced this issue on my laptop. Trying my luck with #6978 by printing rather than logging stdout/stderr of the spawned process.

@andrewor14
Copy link
Contributor

Ok, let's retest this please now that #6978 is merged.

@SparkQA
Copy link

SparkQA commented Jun 24, 2015

Test build #35705 has finished for PR 6957 at commit f8aab7f.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@andrewor14
Copy link
Contributor

retest this please

@@ -563,7 +563,7 @@ private[hive] object HiveContext {
doc = "TODO")

/** Constructs a configuration for hive, where the metastore is located in a temp directory. */
def newTemporaryConfiguration(): Map[String, String] = {
def newTemporaryConfiguration(useInMemoryDerby: Boolean): Map[String, String] = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could just make this default to false

@SparkQA
Copy link

SparkQA commented Jun 24, 2015

Test build #35714 has finished for PR 6957 at commit f8aab7f.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jun 24, 2015

Test build #35717 has finished for PR 6957 at commit 2292dfb.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@yhuai yhuai changed the title [SPARK-8567] [SQL] [WIP] HiveSparkSubmitSuite is flaky [SPARK-8567] [SQL] Increase the timeout of HiveSparkSubmitSuite Jun 24, 2015
@andrewor14
Copy link
Contributor

LGTM as a temporary fix. Let's merge this into master and 1.4 and see if it fixes the test failures.

@asfgit asfgit closed this in 7daa702 Jun 24, 2015
asfgit pushed a commit that referenced this pull request Jun 24, 2015
https://issues.apache.org/jira/browse/SPARK-8567

Author: Yin Huai <[email protected]>

Closes #6957 from yhuai/SPARK-8567 and squashes the following commits:

62dff5b [Yin Huai] Increase the timeout.

Conflicts:
	sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveSparkSubmitSuite.scala
@andrewor14
Copy link
Contributor

I will leave the JIRA open for a day or two until after we can verify that this fixes it.

@SparkQA
Copy link

SparkQA commented Jun 25, 2015

Test build #35726 has finished for PR 6957 at commit 62dff5b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class StreamingLinearAlgorithm(object):
    • class StreamingLogisticRegressionWithSGD(StreamingLinearAlgorithm):
    • case class PrecisionInfo(precision: Int, scale: Int)

nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 25, 2015
https://issues.apache.org/jira/browse/SPARK-8567

Author: Yin Huai <[email protected]>

Closes apache#6957 from yhuai/SPARK-8567 and squashes the following commits:

62dff5b [Yin Huai] Increase the timeout.

Conflicts:
	sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveSparkSubmitSuite.scala
@yhuai yhuai deleted the SPARK-8567 branch June 25, 2015 05:18
@liancheng
Copy link
Contributor

@yhuai As for why the log doesn't appear on Jenkins, my guess is that the spark-submit process wasn't started properly because of, for example, some class not found error. I'd suggest to enable SPARK_PRINT_LAUNCH_COMMAND, then login into a Jenkins worker node and try exactly the same command line there. Currently, a super long classpath (it fills two and a half screens of mine...) appear on Jenkins for this test suite. This might be the reason why this error only appear on Jenkins, since classpath can be environment sensitive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants