Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-10231] [MLLIB] update @Since annotation for mllib.classification #8421

Closed
wants to merge 1 commit into from
Closed

[SPARK-10231] [MLLIB] update @Since annotation for mllib.classification #8421

wants to merge 1 commit into from

Conversation

mengxr
Copy link
Contributor

@mengxr mengxr commented Aug 25, 2015

Update @Since annotation in mllib.classification:

  1. add version to classes, objects, constructors, and public variables declared in constructors
  2. correct some versions
  3. remove @Since on toString

@MechCoder @dbtsai

mengxr
mengxr reviewed Aug 25, 2015
View reviewed changes
mllib/src/main/scala/org/apache/spark/mllib/classification/SVM.scala
@Since("0.8.0")
class SVMModel @Since("1.1.0") (
@Since("1.0.0") override val weights: Vector,
@Since("0.8.0") override val intercept: Double)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This means the class is since 0.8, the constructor is since 1.1, weights is since 1.0, and intercept is since 0.8.

@SparkQA
Copy link

SparkQA commented Aug 25, 2015

Test build #41542 has finished for PR 8421 at commit b2dce80.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class LogisticRegressionModel @Since("1.3.0") (
    • class SVMModel @Since("1.1.0") (
    • abstract class SetOperation(left: LogicalPlan, right: LogicalPlan) extends BinaryNode
    • case class Union(left: LogicalPlan, right: LogicalPlan) extends SetOperation(left, right)
    • case class Intersect(left: LogicalPlan, right: LogicalPlan) extends SetOperation(left, right)
    • case class Except(left: LogicalPlan, right: LogicalPlan) extends SetOperation(left, right)

This was referenced Aug 25, 2015
Closed
Closed
asfgit pushed a commit that referenced this pull request Aug 25, 2015
@mengxr
[SPARK-10231] [MLLIB] update @SInCE annotation for mllib.classification
5a32ed7 
Update `Since` annotation in `mllib.classification`:

1. add version to classes, objects, constructors, and public variables declared in constructors
2. correct some versions
3. remove `Since` on `toString`

MechCoder dbtsai

Author: Xiangrui Meng <[email protected]>

Closes #8421 from mengxr/SPARK-10231 and squashes the following commits:

b2dce80 [Xiangrui Meng] update @SInCE annotation for mllib.classification

(cherry picked from commit 16a2be1)
Signed-off-by: DB Tsai <[email protected]>
@dbtsai
Copy link
Member

dbtsai commented Aug 25, 2015

LGTM. Merged into 1.5 branch and master. Thanks.

@asfgit asfgit closed this in 16a2be1 Aug 25, 2015
This was referenced Aug 25, 2015
Closed
Closed
Closed
asfgit pushed a commit that referenced this pull request Aug 25, 2015
@mengxr
[SPARK-10237] [MLLIB] update since versions in mllib.fpm
c619c75 
Same as #8421 but for `mllib.fpm`.

cc feynmanliang

Author: Xiangrui Meng <[email protected]>

Closes #8429 from mengxr/SPARK-10237.
asfgit pushed a commit that referenced this pull request Aug 25, 2015
@mengxr
[SPARK-10237] [MLLIB] update since versions in mllib.fpm
186326d 
Same as #8421 but for `mllib.fpm`.

cc feynmanliang

Author: Xiangrui Meng <[email protected]>

Closes #8429 from mengxr/SPARK-10237.

(cherry picked from commit c619c75)
Signed-off-by: Xiangrui Meng <[email protected]>
@mengxr mengxr mentioned this pull request Aug 25, 2015
Closed
asfgit pushed a commit that referenced this pull request Aug 25, 2015
@mengxr
[SPARK-10239] [SPARK-10244] [MLLIB] update since versions in mllib.pm…
6f05b7a 
…ml and mllib.util

Same as #8421 but for `mllib.pmml` and `mllib.util`.

cc dbtsai

Author: Xiangrui Meng <[email protected]>

Closes #8430 from mengxr/SPARK-10239 and squashes the following commits:

a189acf [Xiangrui Meng] update since versions in mllib.pmml and mllib.util

(cherry picked from commit 00ae4be)
Signed-off-by: DB Tsai <[email protected]>
asfgit pushed a commit that referenced this pull request Aug 25, 2015
@mengxr
[SPARK-10239] [SPARK-10244] [MLLIB] update since versions in mllib.pm…
00ae4be 
…ml and mllib.util

Same as #8421 but for `mllib.pmml` and `mllib.util`.

cc dbtsai

Author: Xiangrui Meng <[email protected]>

Closes #8430 from mengxr/SPARK-10239 and squashes the following commits:

a189acf [Xiangrui Meng] update since versions in mllib.pmml and mllib.util
@mengxr mengxr mentioned this pull request Aug 26, 2015
Closed
asfgit pushed a commit that referenced this pull request Aug 26, 2015
@mengxr
[SPARK-10233] [MLLIB] update since version in mllib.evaluation
af98e51 
Same as #8421 but for `mllib.evaluation`.

cc avulanov

Author: Xiangrui Meng <[email protected]>

Closes #8423 from mengxr/SPARK-10233.

(cherry picked from commit 8668ead)
Signed-off-by: Xiangrui Meng <[email protected]>
asfgit pushed a commit that referenced this pull request Aug 26, 2015
@mengxr
[SPARK-10233] [MLLIB] update since version in mllib.evaluation
8668ead 
Same as #8421 but for `mllib.evaluation`.

cc avulanov

Author: Xiangrui Meng <[email protected]>

Closes #8423 from mengxr/SPARK-10233.
@mengxr mengxr mentioned this pull request Aug 26, 2015
Closed
asfgit pushed a commit that referenced this pull request Aug 26, 2015
@mengxr
[SPARK-10238] [MLLIB] update since versions in mllib.linalg
46750b9 
Same as #8421 but for `mllib.linalg`.

cc dbtsai

Author: Xiangrui Meng <[email protected]>

Closes #8440 from mengxr/SPARK-10238 and squashes the following commits:

b38437e [Xiangrui Meng] update since versions in mllib.linalg

(cherry picked from commit ab431f8)
Signed-off-by: DB Tsai <[email protected]>
asfgit pushed a commit that referenced this pull request Aug 26, 2015
@mengxr
[SPARK-10238] [MLLIB] update since versions in mllib.linalg
ab431f8 
Same as #8421 but for `mllib.linalg`.

cc dbtsai

Author: Xiangrui Meng <[email protected]>

Closes #8440 from mengxr/SPARK-10238 and squashes the following commits:

b38437e [Xiangrui Meng] update since versions in mllib.linalg
@mengxr mengxr mentioned this pull request Aug 26, 2015
Closed
asfgit pushed a commit that referenced this pull request Aug 26, 2015
@mengxr
[SPARK-10234] [MLLIB] update since version in mllib.clustering
d703372 
Same as #8421 but for `mllib.clustering`.

cc feynmanliang yu-iskw

Author: Xiangrui Meng <[email protected]>

Closes #8435 from mengxr/SPARK-10234.
asfgit pushed a commit that referenced this pull request Aug 26, 2015
@mengxr
[SPARK-10234] [MLLIB] update since version in mllib.clustering
be0c991 
Same as #8421 but for `mllib.clustering`.

cc feynmanliang yu-iskw

Author: Xiangrui Meng <[email protected]>

Closes #8435 from mengxr/SPARK-10234.

(cherry picked from commit d703372)
Signed-off-by: Xiangrui Meng <[email protected]>
asfgit pushed a commit that referenced this pull request Aug 26, 2015
@mengxr
[SPARK-10243] [MLLIB] update since versions in mllib.tree
fb7e12f 
Same as #8421 but for `mllib.tree`.

cc jkbradley

Author: Xiangrui Meng <[email protected]>

Closes #8442 from mengxr/SPARK-10236.
asfgit pushed a commit that referenced this pull request Aug 26, 2015
@mengxr
[SPARK-10243] [MLLIB] update since versions in mllib.tree
6d8ebc8 
Same as #8421 but for `mllib.tree`.

cc jkbradley

Author: Xiangrui Meng <[email protected]>

Closes #8442 from mengxr/SPARK-10236.

(cherry picked from commit fb7e12f)
Signed-off-by: Xiangrui Meng <[email protected]>
asfgit pushed a commit that referenced this pull request Aug 26, 2015
@mengxr
[SPARK-10235] [MLLIB] update since versions in mllib.regression
4657fa1 
Same as #8421 but for `mllib.regression`.

cc freeman-lab dbtsai

Author: Xiangrui Meng <[email protected]>

Closes #8426 from mengxr/SPARK-10235 and squashes the following commits:

6cd28e4 [Xiangrui Meng] update since versions in mllib.regression
asfgit pushed a commit that referenced this pull request Aug 26, 2015
@mengxr
[SPARK-10235] [MLLIB] update since versions in mllib.regression
08d390f 
Same as #8421 but for `mllib.regression`.

cc freeman-lab dbtsai

Author: Xiangrui Meng <[email protected]>

Closes #8426 from mengxr/SPARK-10235 and squashes the following commits:

6cd28e4 [Xiangrui Meng] update since versions in mllib.regression

(cherry picked from commit 4657fa1)
Signed-off-by: DB Tsai <[email protected]>
asfgit pushed a commit that referenced this pull request Aug 26, 2015
@mengxr
[SPARK-10236] [MLLIB] update since versions in mllib.feature
21a10a8 
Same as #8421 but for `mllib.feature`.

cc dbtsai

Author: Xiangrui Meng <[email protected]>

Closes #8449 from mengxr/SPARK-10236.feature and squashes the following commits:

0e8d658 [Xiangrui Meng] remove unnecessary comment
ad70b03 [Xiangrui Meng] update since versions in mllib.feature

(cherry picked from commit 321d775)
Signed-off-by: DB Tsai <[email protected]>
asfgit pushed a commit that referenced this pull request Aug 26, 2015
@mengxr
[SPARK-10236] [MLLIB] update since versions in mllib.feature
321d775 
Same as #8421 but for `mllib.feature`.

cc dbtsai

Author: Xiangrui Meng <[email protected]>

Closes #8449 from mengxr/SPARK-10236.feature and squashes the following commits:

0e8d658 [Xiangrui Meng] remove unnecessary comment
ad70b03 [Xiangrui Meng] update since versions in mllib.feature
asfgit pushed a commit that referenced this pull request Aug 26, 2015
@mengxr
[SPARK-10241] [MLLIB] update since versions in mllib.recommendation
efbd7af 
Same as #8421 but for `mllib.recommendation`.

cc srowen coderxiang

Author: Xiangrui Meng <[email protected]>

Closes #8432 from mengxr/SPARK-10241.

(cherry picked from commit 086d468)
Signed-off-by: Xiangrui Meng <[email protected]>
asfgit pushed a commit that referenced this pull request Aug 26, 2015
@mengxr
[SPARK-10241] [MLLIB] update since versions in mllib.recommendation
086d468 
Same as #8421 but for `mllib.recommendation`.

cc srowen coderxiang

Author: Xiangrui Meng <[email protected]>

Closes #8432 from mengxr/SPARK-10241.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mengxr @SparkQA @dbtsai