[SPARK-10617] [SQL] Fixed AddMonths leap year calculations #8980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -295,6 +295,8 @@ class DateExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper { | |||
| test("add_months") { | |||
| checkEvaluation(AddMonths(Literal(Date.valueOf("2015-01-30")), Literal(1)), | |||
| DateTimeUtils.fromJavaDate(Date.valueOf("2015-02-28"))) | |||
| checkEvaluation(AddMonths(Literal(Date.valueOf("2015-02-28")), Literal(12)), | |||
| DateTimeUtils.fromJavaDate(Date.valueOf("2016-02-28"))) | |||
There was a problem hiding this comment.
This is not the expected answer, Hive/Oracle will return 2016/02/29
|
@alexrovner actually this PR is opened against the wrong branch. Would you mind closing this and re-opening against the master branch? Once you do that we will start reviewing it. |
|
Test build #47746 has finished for PR 8980 at commit
|
|
@alexrovner Could you close this PR since the JIRA had been closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.