Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPARK-10262 Add @Since annotation to ml.attribute #9046

Closed
wants to merge 4 commits into from
Closed

SPARK-10262 Add @Since annotation to ml.attribute #9046

wants to merge 4 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Oct 9, 2015

@SInCE annotations for ml.attribute. Most appear to belong 1.4.0 with several exceptions. Please review.

https://issues.apache.org/jira/browse/SPARK-10262

@srowen
Copy link
Member

srowen commented Oct 9, 2015

(Please give this a more complete title and description, as in the JIRA)

@ghost ghost changed the title Spark 10262 SPARK-10262 Add @Since annotation to ml.attribute Oct 9, 2015
@SparkQA
Copy link

SparkQA commented Oct 9, 2015

Test build #1867 has finished for PR 9046 at commit eb37a0d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • sealed abstract class AttributeType(@Since("1.4.0") val name: String)

@mengxr
Copy link
Contributor

mengxr commented Oct 9, 2015

@hucares This could be my fault. Do you see any non-DeveloperApi under ml.attribute?

@ghost
Copy link
Author

ghost commented Oct 9, 2015

@mengxr There are only DeveloperApi and now Since annotations under ml.attribute. I'm still pretty raw at Scala so I'm not sure why annotating a sealed abstract class creates a new experimental class.

@srowen
Copy link
Member

srowen commented Jan 25, 2016

@hucares I think you can close this PR. As you say in the JIRA, there are no non-Developer non-private APIs in this package.

@asfgit asfgit closed this in ef8fb36 Jan 25, 2016
@mengxr
Copy link
Contributor

mengxr commented Jan 25, 2016

I closed this PR. @hucares I'm sorry for not checking the API visibility when I created the JIRA. Please feel free to pick another starter task and I'm happy to walk you through the process of contributing to Spark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants