Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-11343] [ML] Documentation of float and double prediction/label columns in RegressionEvaluator #9598

Closed
wants to merge 3 commits into from
Closed

[SPARK-11343] [ML] Documentation of float and double prediction/label columns in RegressionEvaluator #9598

wants to merge 3 commits into from

Conversation

dahlem
Copy link
Contributor

@dahlem dahlem commented Nov 10, 2015

@felixcheung , @mengxr

Just added a message to require()

@jkbradley
Copy link
Member

LGTM pending tests

@SparkQA
Copy link

SparkQA commented Nov 23, 2015

Test build #2098 has finished for PR 9598 at commit c83588a.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@felixcheung
Copy link
Member

looks good, perhaps reuse predictionColName and labelColName, instead of $(predictionCol) and $(labelCol), but it is minor

@jkbradley
Copy link
Member

@dahlem Can you please fix the scala style problems?

@dahlem
Copy link
Contributor Author

dahlem commented Dec 2, 2015

Will do.

On Wed, Dec 2, 2015 at 12:57 AM, jkbradley [email protected] wrote:

@dahlem https://github.com/dahlem Can you please fix the scala style
problems?

—
Reply to this email directly or view it on GitHub
#9598 (comment).

@jkbradley
Copy link
Member

Ping

@dahlem
Copy link
Contributor Author

dahlem commented Dec 8, 2015

@jkbradley done

@jkbradley
Copy link
Member

LGTM pending tests ( @felixcheung 's comment is valid, but I guess we can fix it later)

@SparkQA
Copy link

SparkQA commented Dec 9, 2015

Test build #2186 has finished for PR 9598 at commit 2ccd177.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jkbradley
Copy link
Member

merging with master and branch-1.6

asfgit pushed a commit that referenced this pull request Dec 9, 2015
@dahlem @jkbradley
[SPARK-11343][ML] Documentation of float and double prediction/label …
9e82273 
…columns in RegressionEvaluator

felixcheung , mengxr

Just added a message to require()

Author: Dominik Dahlem <[email protected]>

Closes #9598 from dahlem/ddahlem_regression_evaluator_double_predictions_message_04112015.

(cherry picked from commit a0046e3)
Signed-off-by: Joseph K. Bradley <[email protected]>
@asfgit asfgit closed this in a0046e3 Dec 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dahlem @jkbradley @SparkQA @felixcheung