Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nginx configuration parameters as environment variables #2199

Closed
obermeier opened this issue Nov 17, 2023 · 0 comments · Fixed by #2203
Closed

Nginx configuration parameters as environment variables #2199

obermeier opened this issue Nov 17, 2023 · 0 comments · Fixed by #2203
Labels
enhancement New feature or request
Milestone

Comments

@obermeier
Copy link
Member

With the new modules extensions-all-jvm and extensions-iiot-minimal the nginx configuration should be updated to be able to use the HTTP-Server adapter the established way.

Since the hostname of the service could differ (extensions-all-jvm, extensions-iiot-minimal, ...), what do you think of the idea of adding an option to set the host via an environment variable.
The current ui docker image contains the tool envsubst which is able to set the values in the nginx configuration.

A short example: Link

@obermeier obermeier added the enhancement New feature or request label Nov 17, 2023
@bossenti bossenti linked a pull request Dec 18, 2023 that will close this issue
@bossenti bossenti added this to the 0.95.0 milestone Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants