diff --git a/superset-frontend/src/components/Datasource/DatasourceEditor.jsx b/superset-frontend/src/components/Datasource/DatasourceEditor.jsx index bfb55e20f31df..e821ddb276e51 100644 --- a/superset-frontend/src/components/Datasource/DatasourceEditor.jsx +++ b/superset-frontend/src/components/Datasource/DatasourceEditor.jsx @@ -1271,7 +1271,6 @@ class DatasourceEditor extends React.PureComponent { @@ -1291,25 +1290,27 @@ class DatasourceEditor extends React.PureComponent { } key={3} > - - this.setColumns({ calculatedColumns }) - } - onDatasourceChange={this.onDatasourceChange} - datasource={datasource} - editableColumnName - showExpression - allowAddItem - allowEditDataType - itemGenerator={() => ({ - column_name: '', - filterable: true, - groupby: true, - expression: '', - __expanded: true, - })} - /> + + + this.setColumns({ calculatedColumns }) + } + onDatasourceChange={this.onDatasourceChange} + datasource={datasource} + editableColumnName + showExpression + allowAddItem + allowEditDataType + itemGenerator={() => ({ + column_name: '', + filterable: true, + groupby: true, + expression: '', + __expanded: true, + })} + /> + diff --git a/superset-frontend/src/components/Datasource/DatasourceEditor.test.jsx b/superset-frontend/src/components/Datasource/DatasourceEditor.test.jsx index c3904d743737c..dec75afdc33c9 100644 --- a/superset-frontend/src/components/Datasource/DatasourceEditor.test.jsx +++ b/superset-frontend/src/components/Datasource/DatasourceEditor.test.jsx @@ -78,7 +78,7 @@ describe('DatasourceEditor', () => { }); userEvent.click(getToggles[0]); const getTextboxes = screen.getAllByRole('textbox'); - expect(getTextboxes.length).toEqual(12); + expect(getTextboxes.length).toEqual(5); const inputLabel = screen.getByPlaceholderText('Label'); const inputDescription = screen.getByPlaceholderText('Description');