From 36ed617090b72ad3cb7b587daa05f9d0dd984e7b Mon Sep 17 00:00:00 2001 From: John Bodley <4567245+john-bodley@users.noreply.github.com> Date: Mon, 2 Oct 2023 14:32:21 -0700 Subject: [PATCH] fix: Address Mypy issue which is causing CI to fail (#25494) --- tests/unit_tests/db_engine_specs/test_clickhouse.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/unit_tests/db_engine_specs/test_clickhouse.py b/tests/unit_tests/db_engine_specs/test_clickhouse.py index 6dfeddaf37cfd..3f28341f2643d 100644 --- a/tests/unit_tests/db_engine_specs/test_clickhouse.py +++ b/tests/unit_tests/db_engine_specs/test_clickhouse.py @@ -30,6 +30,8 @@ String, TypeEngine, ) +from urllib3.connection import HTTPConnection +from urllib3.exceptions import NewConnectionError from superset.utils.core import GenericDataType from tests.unit_tests.db_engine_specs.utils import ( @@ -56,14 +58,12 @@ def test_convert_dttm( def test_execute_connection_error() -> None: - from urllib3.exceptions import NewConnectionError - from superset.db_engine_specs.clickhouse import ClickHouseEngineSpec from superset.db_engine_specs.exceptions import SupersetDBAPIDatabaseError cursor = Mock() cursor.execute.side_effect = NewConnectionError( - "Dummypool", "Exception with sensitive data" + HTTPConnection("localhost"), "Exception with sensitive data" ) with pytest.raises(SupersetDBAPIDatabaseError) as ex: ClickHouseEngineSpec.execute(cursor, "SELECT col1 from table1")