From 5ca3c1bde8f69b86544a17481a382d36f09e1812 Mon Sep 17 00:00:00 2001 From: rtexelm Date: Wed, 27 Mar 2024 02:37:15 -0400 Subject: [PATCH] Add semantic-object-key-val as argument for onHover prop --- .../src/dashboard/components/gridComponents/Row.jsx | 3 ++- .../src/dashboard/components/menu/HoverMenu.tsx | 12 +++++++----- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/superset-frontend/src/dashboard/components/gridComponents/Row.jsx b/superset-frontend/src/dashboard/components/gridComponents/Row.jsx index 5a3a0ab93bcc4..b6dc042a2b094 100644 --- a/superset-frontend/src/dashboard/components/gridComponents/Row.jsx +++ b/superset-frontend/src/dashboard/components/gridComponents/Row.jsx @@ -238,7 +238,8 @@ class Row extends React.PureComponent { } handleMenuHover = hovered => { - this.setState(() => ({ hoverMenuHovered: hovered })); + const { isHovered } = hovered; + this.setState(() => ({ hoverMenuHovered: isHovered })); }; render() { diff --git a/superset-frontend/src/dashboard/components/menu/HoverMenu.tsx b/superset-frontend/src/dashboard/components/menu/HoverMenu.tsx index 09cec71584eb5..59c77bee282b6 100644 --- a/superset-frontend/src/dashboard/components/menu/HoverMenu.tsx +++ b/superset-frontend/src/dashboard/components/menu/HoverMenu.tsx @@ -25,7 +25,7 @@ interface HoverMenuProps { position: 'left' | 'top'; innerRef: RefObject; children: React.ReactNode; - onHover?: (isHovered: boolean) => void; + onHover?: (data: { isHovered: boolean }) => void; } const HoverStyleOverrides = styled.div` @@ -73,14 +73,16 @@ export default class HoverMenu extends React.PureComponent { }; handleMouseEnter = () => { - if (this.props.onHover) { - this.props.onHover(true); + const { onHover } = this.props; + if (onHover) { + onHover({ isHovered: true }); } }; handleMouseLeave = () => { - if (this.props.onHover) { - this.props.onHover(false); + const { onHover } = this.props; + if (onHover) { + onHover({ isHovered: false }); } };