From a7672ebdd1cbbbbd804ab3f62dd28cf0e8feadcb Mon Sep 17 00:00:00 2001 From: Maxime Beauchemin Date: Fri, 19 Aug 2016 16:50:05 -0700 Subject: [PATCH] [bugfix] dashboard list doesn't populate in explore->saveas (#979) --- caravel/assets/javascripts/welcome.js | 5 +++-- caravel/views.py | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/caravel/assets/javascripts/welcome.js b/caravel/assets/javascripts/welcome.js index d83cd3e7ee920..4cc6a3c77e720 100644 --- a/caravel/assets/javascripts/welcome.js +++ b/caravel/assets/javascripts/welcome.js @@ -14,13 +14,14 @@ function modelViewTable(selector, modelView, orderCol, order) { url += '?_oc_' + modelView + '=' + orderCol; url += '&_od_' + modelView + '=' + order; $.getJSON(url, function (data) { + const columns = ['dashboard_link', 'creator', 'modified']; const tableData = $.map(data.result, function (el) { - const row = $.map(data.list_columns, function (col) { + const row = $.map(columns, function (col) { return el[col]; }); return [row]; }); - const cols = $.map(data.list_columns, function (col) { + const cols = $.map(columns, function (col) { return { sTitle: data.label_columns[col] }; }); const panel = $(selector).parents('.panel'); diff --git a/caravel/views.py b/caravel/views.py index 59219d2b4741e..4c45dffacf948 100755 --- a/caravel/views.py +++ b/caravel/views.py @@ -747,7 +747,7 @@ def pre_delete(self, obj): class DashboardModelViewAsync(DashboardModelView): # noqa - list_columns = ['dashboard_link', 'creator', 'modified'] + list_columns = ['dashboard_link', 'creator', 'modified', 'dashboard_title'] label_columns = { 'dashboard_link': 'Dashboard', }