diff --git a/superset-frontend/src/dashboard/components/DashboardBuilder/DashboardContainer.tsx b/superset-frontend/src/dashboard/components/DashboardBuilder/DashboardContainer.tsx index 7f5588a289d65..b08a7cd6339f5 100644 --- a/superset-frontend/src/dashboard/components/DashboardBuilder/DashboardContainer.tsx +++ b/superset-frontend/src/dashboard/components/DashboardBuilder/DashboardContainer.tsx @@ -27,24 +27,25 @@ import { isFeatureEnabled, } from '@superset-ui/core'; import { ParentSize } from '@vx/responsive'; +import pick from 'lodash/pick'; import Tabs from 'src/components/Tabs'; import DashboardGrid from 'src/dashboard/containers/DashboardGrid'; -import getLeafComponentIdFromPath from 'src/dashboard/util/getLeafComponentIdFromPath'; import { ChartsState, DashboardLayout, LayoutItem, RootState, } from 'src/dashboard/types'; +import getLeafComponentIdFromPath from 'src/dashboard/util/getLeafComponentIdFromPath'; import { DASHBOARD_GRID_ID, DASHBOARD_ROOT_DEPTH, } from 'src/dashboard/util/constants'; +import { getChartIdsInFilterScope } from 'src/dashboard/util/getChartIdsInFilterScope'; +import findTabIndexByComponentId from 'src/dashboard/util/findTabIndexByComponentId'; +import { setInScopeStatusOfFilters } from 'src/dashboard/actions/nativeFilters'; import { getRootLevelTabIndex, getRootLevelTabsComponent } from './utils'; -import { getChartIdsInFilterScope } from '../../util/getChartIdsInFilterScope'; -import findTabIndexByComponentId from '../../util/findTabIndexByComponentId'; import { findTabsWithChartsInScope } from '../nativeFilters/utils'; -import { setInScopeStatusOfFilters } from '../../actions/nativeFilters'; import { NATIVE_FILTER_DIVIDER_PREFIX } from '../nativeFilters/FiltersConfigModal/utils'; type DashboardContainerProps = { @@ -58,11 +59,9 @@ const useNativeFilterScopes = () => { return useMemo( () => nativeFilters - ? Object.values(nativeFilters).map((filter: Filter) => ({ - id: filter.id, - scope: filter.scope, - type: filter.type, - })) + ? Object.values(nativeFilters).map((filter: Filter) => + pick(filter, ['id', 'scope', 'type']), + ) : [], [JSON.stringify(nativeFilters)], ); diff --git a/superset-frontend/src/dashboard/components/FiltersBadge/selectors.ts b/superset-frontend/src/dashboard/components/FiltersBadge/selectors.ts index dce3ac9a406d3..0b84c73411db2 100644 --- a/superset-frontend/src/dashboard/components/FiltersBadge/selectors.ts +++ b/superset-frontend/src/dashboard/components/FiltersBadge/selectors.ts @@ -28,10 +28,10 @@ import { } from '@superset-ui/core'; import { NO_TIME_RANGE, TIME_FILTER_MAP } from 'src/explore/constants'; import { getChartIdsInFilterBoxScope } from 'src/dashboard/util/activeDashboardFilters'; +import { CHART_TYPE } from 'src/dashboard/util/componentTypes'; import { ChartConfiguration } from 'src/dashboard/reducers/types'; +import { Layout } from 'src/dashboard/types'; import { areObjectsEqual } from 'src/reduxUtils'; -import { Layout } from '../../types'; -import { CHART_TYPE } from '../../util/componentTypes'; export enum IndicatorStatus { Unset = 'UNSET',