Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIP-15] time_range_endpoints not working on database extra parameters #11657

Closed
rubenSastre opened this issue Nov 11, 2020 · 5 comments
Closed
Labels
!deprecated-label:bug Deprecated label - Use #bug instead sip Superset Improvement Proposal

Comments

@rubenSastre
Copy link
Contributor

With SIP_15 the default time_range_endpoints = [start, end)
There is an option to set you own option on the database extra parameter.
The value for time_range_endpoints on database extra parameter is not working when you create a new chart.

Expected results

While creating a new Chart it should get the value for extra param on the database configuration instead of "time_range_endpoints":["inclusive","exclusive"]

Actual results

Although there is a value set on de database param as "time_range_endpoints":["inclusive","inclusive"] is taking "time_range_endpoints":["inclusive","exclusive"]

Screenshots

image
image

How to reproduce the bug

  1. Set "time_range_endpoints":["inclusive","inclusive"] on the database extra param
  2. Create a new chart
  3. Check on the form_data the value for time_range_endpoints

Environment

  • superset version: 0.37.2
  • python version: 3.7
  • node.js version: node -v
@rubenSastre rubenSastre added the !deprecated-label:bug Deprecated label - Use #bug instead label Nov 11, 2020
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label #bug to this issue, with a confidence of 0.94. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@villebro villebro self-assigned this Nov 11, 2020
@villebro
Copy link
Member

Thanks for reporting @rubenSastre , I'll take a look

@rubenSastre
Copy link
Contributor Author

Any idea? i tried to look on the code but with my level I am not able to solve this part...

@rubenSastre
Copy link
Contributor Author

#11998

@rusackas
Copy link
Member

Since this issue was opened against a version of Superset that's no longer supported, and the thread hasn't seen any love in a long time, I'm going to go ahead and close this. If anyone can reproduce such an error in the current incarnations of Superset, let's open a fresh issue with updated context/screenshots/repro steps. Thank you!

@rusackas rusackas closed this as not planned Won't fix, can't repro, duplicate, stale Dec 20, 2022
@rusackas rusackas added the sip Superset Improvement Proposal label Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
!deprecated-label:bug Deprecated label - Use #bug instead sip Superset Improvement Proposal
Projects
Status: Denied / Closed / Discarded
Development

No branches or pull requests

5 participants