[Explore] Timepicker time range interval design

[graceguo-supercat]

How to reproduce the bug

1. Go to explore view, click Date picker, choose Previous range type
2. Current month is Jan, previous month should include 12/31

Actual results

Environment

latest master

cc @junlincc @zuzana-vej @zhaoyongjie

[graceguo-supercat]

2020-12-01 <= col < 2020-12-31 means include 12-01, not include 12-31.

[junlincc]

looks like this is happening in all time setting(custom, last and previous), and the default state

Screen.Recording.2021-01-05.at.10.13.42.AM.mov

[graceguo-supercat]

If i want to see data of Previous month, it should includes data in 12/31. please check with @zhaoyongjie.

[graceguo-supercat]

for display, Previous month should display as 2020-12-01 <= col < 2021-01-01, and it should include 12/31 data.

[junlincc]

what about changing the END operator to "≤"?

[junlincc]

acknowledging the severity of this bug as it is misleading users reading the chart. my bad not catching it before we merged. Thanks for reporting! 🙏

[graceguo-supercat]

i feel we should display 2020-12-01 <= col < 2021-01-01 not 2020-12-01 <= col <= 2021-12-31.
This will be consistent with all other time range display format, which means include begin, exclude end.

[junlincc]

im suggesting to make this change universal and i believe using "<" is a bug not by design

looking at the old time picker, it had a similar problem on pill display. but actually including both start and end dates in the query.

[john-bodley]

@junlincc see SIP-15 as to why the start and end time range intervals are inclusive of and exclusive of respectively.