Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Explore] slice standalone mode doesn't work correctly after refresh browser #12358

Closed
2 of 3 tasks
duynguyenhoang opened this issue Jan 8, 2021 · 1 comment
Closed
2 of 3 tasks
Labels
!deprecated-label:viz:explore:others Deprecated label - Use explore instead

Comments

@duynguyenhoang
Copy link
Contributor

When going to standalone slice, for example http://localhost:9000/superset/slice/23/?standalone=true
We wil be redirect to http://localhost:9000/superset/explore/?form_data=%7B%22slice_id%22%3A%2023%7D&standalone=true
In explore screen, the url will be replaced by ful form_data. Currenly it doesn't include standalone=true in final url which cause problem when we refresh the browser. It brings us to visualization design screen instead of standalone chart.

Expected results

Standalone slice should be shown when we refresh page http://localhost:9000/superset/slice/23/?standalone=true

Actual results

Visualization design screen is shown.

How to reproduce the bug

  1. Go to standalone slice, example http://localhost:9000/superset/slice/23/?standalone=true
  2. Waiting it to be rendered fully
  3. Refresh browser (F5 or Ctrl R)
  4. See the page is now visualization design page, not standalone slice

Environment

(please complete the following information):

  • superset version: master
  • python version: 3.8
  • node.js version: 123

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.
@duynguyenhoang duynguyenhoang added the #bug Bug report label Jan 8, 2021
@duynguyenhoang duynguyenhoang changed the title slice standalone mode doesn't work correctly after refresh brownser slice standalone mode doesn't work correctly after refresh browser Jan 8, 2021
@duynguyenhoang duynguyenhoang changed the title slice standalone mode doesn't work correctly after refresh browser [Explore] slice standalone mode doesn't work correctly after refresh browser Jan 8, 2021
@junlincc junlincc added !deprecated-label:viz:explore:others Deprecated label - Use explore instead and removed #bug Bug report labels Jan 8, 2021
@villebro
Copy link
Member

Issue fixed by #12359

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
!deprecated-label:viz:explore:others Deprecated label - Use explore instead
Projects
None yet
Development

No branches or pull requests

3 participants