Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[explore]specify Inclusive start, exclusive end in Timepicker Advanced input #12784

Closed
junlincc opened this issue Jan 27, 2021 · 5 comments
Closed
Labels
enhancement:committed Enhancement planned / committed by a contributor explore:time Related to the time filters in Explore need:design-review Requires input/approval from a Designer

Comments

@junlincc
Copy link
Member

junlincc commented Jan 27, 2021

The actual time range that generated by new time picker in Explore sets Start date/time - inclusive and End date/time - exclusive in all time range setting mode(e.g. last week => 2021-01-20 ≤ col < 2021-01-27, previous year => 2020-01-01 ≤ col < 2021-01-01).
This has been the behavior in Superset since SIP15 which ensures time Intervals consistency. Based on the amount of research conducted and user feedback, we agree that this should be a standard default behavior across all verticals in Superset for the long term.

Feature request: In the time picker popover Advanced range type, we should specify that user's date string input in Start will be interpreted as inclusive, vs. date string in End will be interpreted as exclusive. Design input is needed.

Screen Shot 2021-01-26 at 6 22 06 PM

Custom as well

Screen Shot 2021-01-26 at 6 42 30 PM

Related projects are considering -

  1. Allow user to set time interval preference at system level
  2. Allow user to set time zone at system level

cc @mihir174 @zhaoyongjie @john-bodley

@junlincc junlincc added need:design-review Requires input/approval from a Designer enhancement:committed Enhancement planned / committed by a contributor explore:time Related to the time filters in Explore labels Jan 27, 2021
@junlincc junlincc changed the title [explore]specify Inclusive start, exclusive end in Timepicker Advanced input fields [explore]specify Inclusive start, exclusive end in Timepicker Advanced input Jan 27, 2021
@john-bodley
Copy link
Member

john-bodley commented Jan 27, 2021

@junlincc I was thinking something of the form (BTW I really like the materialization of the actual interval per the and < symbols):

Screen Shot 2021-01-27 at 3 43 45 PM

The time interval preferences and time zone topics should definitely be discussed via a SIP.

The later is quite nuanced as there may be numerous times zones in consideration, i.e., i) the reference time zone of the data (e.g. what actual period a date represents), ii) the time zone of the Superset server (which is likely being used for all the server-side timestamps and the materialization of "now"), and iii) the time zone of the client.

Ideally having (i), (ii), and (iii) use the safe reference is ideal and it ensures consistency throughout. It would be quite problematic if a chart was rendered based on the client time zone as two people in two different time zones would be seeing different renderings of the same chart.

@junlincc
Copy link
Member Author

Thank you, John for your input! Agreed, both topics deserve a SIP to iron out all the considerations, possible solutions and their pros and cons. I consider time zone setting is a very important piece in Superset's international product strategy. I will do some research and put together a SIP soon.
@john-bodley

@mihir174
Copy link
Contributor

Hey, here's how tooltips can be set up to clarify the inclusion/exclusion of start and end dates after details are ironed out in the SIP(s).
Slice 2

@ktmud
Copy link
Member

ktmud commented Jan 28, 2021

@mihir174 I think John's proposal is cleaner and easier to comprehend. Users don't have to hover and it'd be more direct to see the difference between these two fields. What do you think of adding both the tooltips and the label change?

Btw, should we also replace "start date" with "start time" just to be consistent?

@junlincc
Copy link
Member Author

junlincc commented Jan 28, 2021

i'm not sure regular/pure business users can easily understand the meaning of Start (inclusive) and End (exclusive). tooltips to explain what they actually mean could be helpful. Having both makes sense @mihir174

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement:committed Enhancement planned / committed by a contributor explore:time Related to the time filters in Explore need:design-review Requires input/approval from a Designer
Projects
None yet
Development

No branches or pull requests

4 participants