-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[explore]specify Inclusive start, exclusive end in Timepicker Advanced input #12784
Comments
@junlincc I was thinking something of the form (BTW I really like the materialization of the actual interval per the The time interval preferences and time zone topics should definitely be discussed via a SIP. The later is quite nuanced as there may be numerous times zones in consideration, i.e., i) the reference time zone of the data (e.g. what actual period a date represents), ii) the time zone of the Superset server (which is likely being used for all the server-side timestamps and the materialization of "now"), and iii) the time zone of the client. Ideally having (i), (ii), and (iii) use the safe reference is ideal and it ensures consistency throughout. It would be quite problematic if a chart was rendered based on the client time zone as two people in two different time zones would be seeing different renderings of the same chart. |
Thank you, John for your input! Agreed, both topics deserve a SIP to iron out all the considerations, possible solutions and their pros and cons. I consider time zone setting is a very important piece in Superset's international product strategy. I will do some research and put together a SIP soon. |
@mihir174 I think John's proposal is cleaner and easier to comprehend. Users don't have to hover and it'd be more direct to see the difference between these two fields. What do you think of adding both the tooltips and the label change? Btw, should we also replace "start date" with "start time" just to be consistent? |
i'm not sure regular/pure business users can easily understand the meaning of Start (inclusive) and End (exclusive). tooltips to explain what they actually mean could be helpful. Having both makes sense @mihir174 |
The actual time range that generated by new time picker in Explore sets Start date/time - inclusive and End date/time - exclusive in all time range setting mode(e.g. last week => 2021-01-20 ≤ col < 2021-01-27, previous year => 2020-01-01 ≤ col < 2021-01-01).
This has been the behavior in Superset since SIP15 which ensures time Intervals consistency. Based on the amount of research conducted and user feedback, we agree that this should be a standard default behavior across all verticals in Superset for the long term.
Feature request: In the time picker popover Advanced range type, we should specify that user's date string input in Start will be interpreted as inclusive, vs. date string in End will be interpreted as exclusive. Design input is needed.
Custom as well
Related projects are considering -
cc @mihir174 @zhaoyongjie @john-bodley
The text was updated successfully, but these errors were encountered: