Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SQL Lab] Split run button doesn't transition smoothly between disabled and enabled states #12979

Closed
yousoph opened this issue Feb 5, 2021 · 3 comments
Closed

[SQL Lab] Split run button doesn't transition smoothly between disabled and enabled states #12979

yousoph opened this issue Feb 5, 2021 · 3 comments
Labels
sqllab:editor

Comments

@yousoph
Copy link
Member

yousoph commented Feb 5, 2021

Screenshot

screencast.2021-02-05.15-26-24.mp4

Description

When transitioning between a disabled and enabled state, the right side of the split run button in SQL Lab changes color/state a bit later than the left side.

How to repro:

  • In SQL Lab, select a db where you have CTAS and/or CVAS enabled
  • Delete all the text in your SQL Lab tab to see the disabled state. Start typing to see the enabled state
@yousoph
Copy link
Member Author

yousoph commented Feb 5, 2021

@AAfghahi - I noticed this with the new disabled state that you added

@AAfghahi
Copy link
Member

AAfghahi commented Feb 5, 2021

oh yeah this looks bad, I will look through and work on it. Maybe I can just set a timeout or something.

@AAfghahi AAfghahi mentioned this issue Feb 8, 2021
Merged
5 tasks
@zuzana-vej
Copy link
Contributor

resolved a while back based on the linked PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
sqllab:editor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@yousoph @AAfghahi @zuzana-vej @junlincc