Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SQLlab]Parameters Modal Not Appearing #13540

Closed
2 of 3 tasks
yousoph opened this issue Mar 10, 2021 · 1 comment · Fixed by #13563
Closed
2 of 3 tasks

[SQLlab]Parameters Modal Not Appearing #13540

yousoph opened this issue Mar 10, 2021 · 1 comment · Fixed by #13563
Labels
#bug:regression Bugs that are identified as regessions P2 Priority item - High sqllab Namespace | Anything related to the SQL Lab

Comments

@yousoph
Copy link
Member

yousoph commented Mar 10, 2021

How to reproduce the bug

Prereq: set ENABLE_TEMPLATE_PROCESSING = True

  1. Go to SQL Lab
  2. Click the overflow menu on the right of the toolbar
  3. Click "Parameters"

Expected results

Modal appears to set Parameters

Actual results

No modal appears and screen is blank other than the toolbar

Screenshots

image

Environment

  • superset version: master

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.
@yousoph yousoph added the #bug Bug report label Mar 10, 2021
@junlincc junlincc added P2 Priority item - High #bug:regression Bugs that are identified as regessions and removed #bug Bug report labels Mar 10, 2021
@junlincc
Copy link
Member

@yousoph this should be a quick fix. added P2 based on the severity. thanks

@junlincc junlincc changed the title Parameters Modal Not Appearing [SQLlab]Parameters Modal Not Appearing Mar 10, 2021
@junlincc junlincc added the sqllab Namespace | Anything related to the SQL Lab label Mar 10, 2021
@eschutho eschutho mentioned this issue Mar 11, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
#bug:regression Bugs that are identified as regessions P2 Priority item - High sqllab Namespace | Anything related to the SQL Lab
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: always pass a string as a value to ace editor preset-io/superset
2 participants
@yousoph @junlincc