[Dashboard][Share] Share related links are gone

[graceguo-supercat]

SHARE links (share url, share in email etc) are hidden in slice header dropdown list in dashboard:

Screenshots

How to reproduce the bug

1. Go to any dashboard
2. Click on dropdown list for any chart
3. Should be able to share chart by link, by email

Environment

latest master

Checklist

Make sure to follow these steps before submitting your issue - thank you!

• I have checked the superset logs for python stacktraces and included it here as text if there are any.
• I have reproduced the issue with at least the latest released version of superset.
• I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Related to #14076. According to PR’s test description:
check that sharing is menu option is shown by default for Admin/Gamma/Alpha

But admin/alpha/gamma role didn't see share links.

CC @junlincc @zuzana-vej @amitmiran137

[amitmiran137]

I'm unable to reproduce the issue
my steps:

1. make sure/remove from Admin/Alpha/Gamma 2 permissions named:
   a. can share dashboard on superset
   b. can share chart on superset
2. run superset init
3. check Admin/Alpha/Gamma and see that the above permission does exist

anyone else able to reproduce?

[graceguo-supercat]

I can reproduce this way:

• checkout open source master branch,
• build and compile in your local environment,
• run superset init, start local server,
• open any sample dashboard as Admin role.
• can not share dashboard, can not share chart.

Please make sure when you introduce new permissions, old features are still working. I assume sharing should be allowed by default for Admin/Gamma/Alpha roles.

Does all existed users have to manually add or remove some permission? Could you add new permission to Admin/Gamma/Alpha roles by db migration (if necessary)?

[graceguo-supercat]

Hi @amitmiran137 and @junlincc I found what is wrong here: in airbnb we reverted #13306 and #14148 because of performance downgrade. But actually #14148 fixed a few permission related issues in the original PR #14076...So right now we are running with 14076 without extra permission related fixes. :(

[junlincc]

@graceguo-supercat gotcha, glad that you found the cause. not sure what's the best way to fix this issue, but this issue will be added to our test case incase it actually happens. closing issue for now since it's not universal.

[jinghua-qa]

Testcase added