Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[metric]Rename column name with non-english string #16108

Closed
heartcored98 opened this issue Aug 6, 2021 · 6 comments
Closed

[metric]Rename column name with non-english string #16108

heartcored98 opened this issue Aug 6, 2021 · 6 comments
Assignees
Labels
enhancement:committed Enhancement planned / committed by a contributor explore:metrics Related to metrics of Explore

Comments

@heartcored98
Copy link

Is your feature request related to a problem? Please describe.

Hi, I am really enjoying superset, but I am frustrated when I have to rename column with non-english string.
Because if I try to change the column name in Korean (for example metrics column), then generated sql query contains Korean with AS statement. Therefore, BigQuery engine is broken.

Describe the solution you'd like
I would like to manually assign column names of group by and metrics with any-language string, through the chart explore ui.

Since bigquery column name rule does not allows non-english character, I think a field name variable should be prepared separately from the column name in SQL query.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Following images is error message when I assign '날짜' string to one of the metrics column.

image

image

@zhaoyongjie zhaoyongjie added the enhancement:request Enhancement request submitted by anyone from the community label Aug 6, 2021
@zhaoyongjie
Copy link
Member

we will consider this issue in metric refactor project. cc: @junlincc

@junlincc junlincc added enhancement:committed Enhancement planned / committed by a contributor and removed enhancement:request Enhancement request submitted by anyone from the community labels Aug 6, 2021
@junlincc
Copy link
Member

junlincc commented Aug 6, 2021

@heartcored98 we will start the metrics redesign/refactoring in later Q3 to include more column customization.

@junlincc junlincc added the explore:metrics Related to metrics of Explore label Aug 6, 2021
@junlincc junlincc changed the title Rename column name with non-english string [metric]Rename column name with non-english string Aug 6, 2021
@stale
Copy link

stale bot commented Apr 30, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label Apr 30, 2022
@zertyuiop
Copy link

Are there any updates on the issue? This issue is very annoying when using Superset with BigQuery.

@stale stale bot removed the inactive Inactive for >= 30 days label Sep 9, 2022
@zertyuiop
Copy link

Same issue: #3136

@rusackas
Copy link
Member

Closing in favor of #21658 - please take the discussion there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement:committed Enhancement planned / committed by a contributor explore:metrics Related to metrics of Explore
Projects
None yet
Development

No branches or pull requests

5 participants